Allow list filter filtering of None on null date fields

[Ryno]

Currently I'm overriding the DateFieldListFilter, but I think it should possibly be in Django?

# Override Datefield filter (add None)
from django.contrib.admin.filters import FieldListFilter, DateFieldListFilter

class DateFieldListFilter(DateFieldListFilter):
    def __init__(self, field, request, params, model, model_admin, field_path):
        super(DateFieldListFilter, self).__init__(field, request, params, model, model_admin, field_path)
        if field.null:
            self.links += (
                (_('None'), {
                    self.field_generic + 'isnull': str(True),
                }),
                (_('Not None'), {
                    self.field_generic + 'isnull': str(False),
                }),
            )

FieldListFilter.register(                                                                                                                             
    lambda f: isinstance(f, models.DateField), DateFieldListFilter, True)

[Ryno]

Changes committed: ​https://github.com/django/django/pull/3705

[Tim Graham]

Ticket is not fixed until code is merged.

[Tim Graham]

This seems okay, although it might make the UI a bit confusing because the distinction between 'Any date' and 'Has date' isn't so clear.

The patch can be cleaned up a bit if you work through our ​patch review checklist.

[Ryno]

Thanks timgraham, sorry I thought I would get a notification or something about this... will clean it up

[Ryno]

I've reworded a bit it, I hope that looks better?
I looked at the guidelines, and I can't really find a fault?
I'll be happy to clean it up. Maybe I should change it a bit, and have

self.lookup_kwarg_isnull = '%s__isnull' % field_path

[Tim Graham]

​PR

[Tim Graham <timograham@…>]

In 468d8211:

Fixed #23971 -- Added "Has date"/"No date" choices for DateFieldListFilter.

[Ryno]

Replying to Tim Graham <timograham@…>:

In 468d8211:

Fixed #23971 -- Added "Has date"/"No date" choices for DateFieldListFilter.

I just thought I'd bring up a previous comment, about clearer distinction:

Replying to timgraham:

This seems okay, although it might make the UI a bit confusing because the distinction between 'Any date' and 'Has date' isn't so clear.

The patch can be cleaned up a bit if you work through our ​patch review checklist.

That's the main reason I went for Has valid date.

[Tim Graham]

Oh, "Has valid date" left me wondering how/if something could have an "invalid" date.

[Ryno]

Replying to timgraham:

Oh, "Has valid date" left me wondering how/if something could have an "invalid" date.

Oic :) thanks Tim!