Changes between Initial Version and Version 2 of Ticket #23952


Ignore:
Timestamp:
Dec 21, 2015, 9:21:31 AM (9 years ago)
Author:
Tim Graham
Comment:

I updated the description to account for the TEMPLATE_STRING_IF_INVALID setting moving into TEMPLATES OPTIONS. The issue ​is still relevant although the fix may not look so nice since we'd have to override the TEMPLATES setting (list of dictionaries) instead of boolean setting.

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #23952

    • Property Triage Stage Unreviewed → Accepted
    • Property Summary Don't run all template tests with TEMPLATE_STRING_IF_INVALID='INVALID' → Don't run all template tests with string_if_invalid='INVALID'

  • Ticket #23952 – Description

    initial v2  
    1 After the template tests refactor in #23768, I don't think there's a need to run all the template tests with a different value of `TEMPLATE_STRING_IF_INVALID` (see `template_tests/syntax_tests/utils.py`. Instead of `if settings.TEMPLATE_STRING_IF_INVALID:` in a given test, we can add a second assertion to these tests and use `self.settings(TEMPLATE_STRING_IF_INVALID='INVALID')` and then render the template a second time.
     1After the template tests refactor in #23768, I don't think there's a need to run all the template tests with a different value of `string_if_invalid` (see `template_tests/syntax_tests/utils.py`. Instead of `if self.engine.string_if_invalid:` in a given test, we can add a second assertion to these tests and use `self.settings(TEMPLATES={... string_if_invalid='INVALID' ...)` and then render the template a second time.
Back to Top