Opened 10 years ago
Last modified 8 years ago
#23952 closed Cleanup/optimization
Don't run all template tests with TEMPLATE_STRING_IF_INVALID='INVALID' — at Initial Version
| Reported by: | Tim Graham | Owned by: | nobody |
|---|---|---|---|
| Component: | Template system | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | Preston Timmons | Triage Stage: | Accepted |
| Has patch: | no | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
After the template tests refactor in #23768, I don't think there's a need to run all the template tests with a different value of TEMPLATE_STRING_IF_INVALID (see template_tests/syntax_tests/utils.py. Instead of if settings.TEMPLATE_STRING_IF_INVALID: in a given test, we can add a second assertion to these tests and use self.settings(TEMPLATE_STRING_IF_INVALID='INVALID') and then render the template a second time.
Note:
See TracTickets
for help on using tickets.