Changes between Initial Version and Version 1 of Ticket #23929, comment 1


Ignore:
Timestamp:
Nov 28, 2014, 11:50:16 AM (10 years ago)
Author:
Wojtek Ruszczewski

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #23929, comment 1

    initial v1  
    11The patch by ticket (some guessing about the problems):
    2 * #7514 introduces a `clear_cache` statement, that's probably not needed any longer, because a `pre_save` signal clearing the cache was added in the meantime (the test the ticket refers to can be found [https://github.com/django/django/blob/attic/newforms-admin/django/contrib/auth/tests/forms.py here]; removing the statement doesn't seem to cause any failures now);
     2* #7514 introduced a `clear_cache` statement, that's probably not needed any longer, because a `pre_save` signal clearing the cache was added in the meantime (the test the ticket refers to can be found [https://github.com/django/django/blob/attic/newforms-admin/django/contrib/auth/tests/forms.py here]; removing the statement doesn't seem to cause any failures now);
    33* I believe the main issue in #15346 and #15573 was preventing the creation of more than one site;
    4 * #16353 and #16828 are about a multi-database setup, just an `allow_migrate` condition is what is needed currently;
     4* #16353 and #16828 were about a multi-database setup, just an `allow_migrate` condition is what is needed currently;
    55* #17415 has a nice test, but moving it to the new testcase makes it even better (by avoiding the `SitesFrameworkTests.setUp`), the test still fails with PostgreSQL if you remove the sequence resetting part in `create_default_site`.
    66
Back to Top