Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#23900 closed Cleanup/optimization (fixed)

Section on Preventing header injection does not include some imports

Reported by: Kevin Ndung'u Owned by: Kevin Ndung'u
Component: Documentation Version: dev
Severity: Normal Keywords: BadHeaderError, docs
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

The documentation section on Preventing header injection ​https://docs.djangoproject.com/en/1.7/topics/email/#preventing-header-injection, and specifically, the example provided uses HttpResponse and HttpResponseRedirect yet they are not imported.

Change History (7)

comment:1 by Kevin Ndung'u, 10 years ago

Owner: changed from nobody to Kevin Ndung'u
Status: new → assigned

comment:2 by Kevin Ndung'u, 10 years ago

Has patch: set

comment:3 by Berker Peksag, 10 years ago

Component: Uncategorized → Documentation
Triage Stage: Unreviewed → Accepted
Version: 1.7 → master

PR is at ​https://github.com/django/django/pull/3608 and LGTM.

comment:4 by Berker Peksag, 10 years ago

Triage Stage: Accepted → Ready for checkin

comment:5 by Baptiste Mispelon <bmispelon@…>, 10 years ago

Resolution: → fixed
Status: assigned → closed

In 0d74209ef66111f29f122d5f5fdf8e2964890cc5:

Fixed #23900 -- Added missing imports in code example.

The Preventing header injection example included
classes that are not imported.

Thanks to Collin Anderson and Berker Peksağ for the
reviews.

comment:6 by Baptiste Mispelon <bmispelon@…>, 10 years ago

In 22d292e23b1b60fd5c304b3d867ecf70860e7048:

[1.7.x] Fixed #23900 -- Added missing imports in code example.

The Preventing header injection example included
classes that are not imported.

Thanks to Collin Anderson and Berker Peksağ for the
reviews.

Backport of 0d74209ef66111f29f122d5f5fdf8e2964890cc5 from master.

comment:7 by Baptiste Mispelon <bmispelon@…>, 10 years ago

In db227d9d20d848c56f94ce0ca175fde7e1180c21:

[1.6.x] Fixed #23900 -- Added missing imports in code example.

The Preventing header injection example included
classes that are not imported.

Thanks to Collin Anderson and Berker Peksağ for the
reviews.

Backport of 0d74209ef66111f29f122d5f5fdf8e2964890cc5 from master.

Note: See TracTickets for help on using tickets.
Back to Top