Opened 10 years ago

Closed 10 years ago

#23894 closed Cleanup/optimization (fixed)

Favor kwargs over args in migration serializer / deconstruct wherever possible

Reported by: Markus Holtermann Owned by: Markus Holtermann
Component: Migrations Version: 1.7
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no
Pull Requests:3603 merged

Description

For the same reasons as outlined in #23892 (forwards compatibility) Django should use keyword arguments when serializing objects for migration files. This allows potential positional argument removals in the future.

Change History (7)

comment:1 by Markus Holtermann, 10 years ago

Owner: changed from nobody to Markus Holtermann
Status: new → assigned

comment:2 by Markus Holtermann, 10 years ago

Has patch: set

I opened a pull request to unify the deconstruct methods: ​https://github.com/django/django/pull/3603

comment:3 by Carl Meyer, 10 years ago

Patch needs improvement: set

comment:4 by Carl Meyer, 10 years ago

Triage Stage: Unreviewed → Accepted

comment:5 by Markus Holtermann, 10 years ago

Patch needs improvement: unset

comment:6 by Tim Graham, 10 years ago

Triage Stage: Accepted → Ready for checkin

comment:7 by Tim Graham <timograham@…>, 10 years ago

Resolution: → fixed
Status: assigned → closed

In 912ad03226687dae91971ebd7e5cf87521f6b0de:

Fixed #23894 -- Made deconstruct methods favor kwargs over args

Note: See TracTickets for help on using tickets.
Back to Top