Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#23884 closed Cleanup/optimization (fixed)

Consider moving FlatPageSitemap to contrib.flatpages

Reported by: Keryn Knight Owned by: Berker Peksag
Component: contrib.sitemaps Version: dev
Severity: Normal Keywords:
Cc: django@… Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no


The FlatPageSitemap currently exists within the 'core' django.contrib.sitemaps namespace, though it's specific to django.contrib.flatpages. Given a number of modules and moves have happened recently, I'm floating the idea of:

  • Moving FlatPageSitemap to django.contrib.flatpages.sitemaps, which would better reflect it's dependencies (though it still has one to django.contrib.sites), and is more inline with how sitemaps would be packaged in third-party apps (and would allow spinning out flatpages to an external app with less work, if ever desired)
  • Raising a deprecation warning for a release, if importing from the old namespace (like the ContentTypes move and form.util moves)

The documentation currently says The sitemap framework provides a couple convenience classes for common cases, and I'd argue that flatpages isn't all *that* common, these days, though it may have been in the past (before richer packages either built on it or supplanted it, because the ecosystem was smaller)

Change History (9)

comment:1 Changed 9 years ago by Aymeric Augustin

Triage Stage: UnreviewedAccepted

comment:2 Changed 9 years ago by Berker Peksag

Has patch: set
Owner: changed from nobody to Berker Peksag
Status: newassigned

comment:3 Changed 9 years ago by Tim Graham

Patch needs improvement: set

Test failure needs fixing.

comment:4 Changed 9 years ago by Berker Peksag

Patch needs improvement: unset

comment:5 Changed 9 years ago by Tim Graham <timograham@…>

Resolution: fixed
Status: assignedclosed

In 9aeb917dad2c3d4c2830f38d3bfc63699e0ba837:

Fixed #23884 -- Moved FlatPageSitemap into django.contrib.flatpages.

comment:6 Changed 9 years ago by Tim Graham

Has patch: unset
Resolution: fixed
Status: closednew

Please look at silencing the deprecation warning when running the tests in reverse:

comment:7 Changed 9 years ago by Tim Graham <timograham@…>

In 4efe1b79e9462318ff8b2c76a09c5925ad0e0f7c:

Refs #23884 -- Silenced a deprecation warning in sitemaps tests.

comment:8 Changed 9 years ago by Tim Graham

Resolution: fixed
Status: newclosed

comment:9 Changed 9 years ago by Tim Graham <timograham@…>

In c2d5f2903cfaef4f8b17d86f4db706b61073a471:

Removed contrib.flatpages.FlatPageSitemap per deprecation timeline; refs #23884.

Note: See TracTickets for help on using tickets.
Back to Top