Opened 10 years ago
Closed 10 years ago
#23875 closed Cleanup/optimization (fixed)
Clean up Query.get_count() implementation
Reported by: | Anssi Kääriäinen | Owned by: | nobody |
---|---|---|---|
Component: | Database layer (models, ORM) | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Accepted | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | yes |
Easy pickings: | no | UI/UX: | no |
Description
The Query.get_count() implementation can be significantly cleaned up. I believe get_count()/add_count_column() was implemented before aggregation support. We can now get rid of this code.
Change History (2)
comment:1 by , 10 years ago
Patch needs improvement: | set |
---|
comment:2 by , 10 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
In c7fd9b242d2d63406f1de6cc3204e35aaa025233: