Opened 3 years ago

Closed 2 weeks ago

Last modified 2 weeks ago

#23821 closed Cleanup/optimization (duplicate)

Remove bundled six

Reported by: Markus Holtermann Owned by: Markus Holtermann
Component: Utilities Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Django historically ships with a bundled version of six in django.utils.six. Now that ensurepip landed in the Python 2.x branch (http://legacy.python.org/dev/peps/pep-0477/) we can safely use dependencies to other Python projects and should move Django's custom methods to something like django.utils.compat.

Change History (8)

comment:1 Changed 3 years ago by Claude Paroz

It's good to see progress on that side, but let's not forget that from a commit in the 2.x branch until it lands on user machines, time may pass. I'm not sure stable distros do patch all these sort of commits. I wouldn't make the move for the Django 1.8 release.

comment:2 Changed 3 years ago by Tim Graham

Triage Stage: UnreviewedAccepted

I have been looking into whether or not we can get some of our customization's (the assertions) merged into six. We could then probably move the memoryview stuff elsewhere so we are at least not making customizations. We should talk at the sprints tomorrow. I think we could probably start the deprecation of utils.six in 1.8, but seconds opinion welcome as I don't fully understand the issues that have historically prevented us from being able to use dependencies.

comment:3 Changed 3 years ago by Aymeric Augustin

I don't think we should remove django.utils.six until we should drop support for Python 2. The maintenance workload is very low.

We're OK with requiring dependencies for some features, however, I don't think we're OK with requiring dependencies for simply starting a hello-world django project.

comment:4 Changed 3 years ago by Claude Paroz

Resolution: wontfix
Status: newclosed

+1 to what Aymeric said, I don't see the gain to do that move for a library that is going to die sooner or later.

comment:5 Changed 2 weeks ago by Frank Sachsenheim

Cc: Frank Sachsenheim added
Resolution: wontfix
Status: closednew
Summary: Remove bundled six and replace it with a upstream dependencyRemove bundled six
Triage Stage: AcceptedUnreviewed

while support for Python 2 was removed, this module is still hanging around in the code and could be removed, couldn't it?

comment:6 Changed 2 weeks ago by Aymeric Augustin

It needs to stay until all supported versions of Django only run on Python 3.x.

Until then, we want third-party apps to be able to import django.utils.six on all supported Django versions.

comment:7 Changed 2 weeks ago by Aymeric Augustin

Resolution: duplicate
Status: newclosed

... which is tracked in #27753.

comment:8 Changed 2 weeks ago by Frank Sachsenheim

Cc: Frank Sachsenheim removed

oh sorry, i was looking for 'six' in the summary field, so that didn't turn up.

Note: See TracTickets for help on using tickets.
Back to Top