Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#23799 closed Bug (fixed)

squashmigrations --no-optimize still optimizes

Reported by: Tillmann Karras Owned by: Tillmann Karras
Component: Migrations Version: master
Severity: Normal Keywords:
Cc: info+coding@… Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description (last modified by Tillmann Karras)

The --no-optimize option doesn't have any effect.

See pull request 3500.

Change History (13)

comment:1 Changed 6 years ago by Tillmann Karras

Description: modified (diff)

comment:2 Changed 6 years ago by Markus Holtermann

Cc: info+coding@… added

comment:3 Changed 6 years ago by Markus Holtermann

Needs tests: set

Though its a rather small patch I'd like to see a test for the now working feature.

comment:4 Changed 6 years ago by Tim Graham

Triage Stage: UnreviewedAccepted

comment:5 Changed 6 years ago by Deni Bertovic

Owner: changed from nobody to Deni Bertovic
Status: newassigned

comment:6 Changed 6 years ago by avojnovicDk

Owner: changed from Deni Bertovic to avojnovicDk

comment:7 Changed 6 years ago by Tillmann Karras

@avojnovicDk: Are you at DjangoUnderTheHood? I forgot to set the owner, now we might be working on the same thing.

comment:8 Changed 6 years ago by Yamila

Needs tests: unset

there is PR

https://github.com/django/django/pull/3521

we didn't see this thread updated till the login... I made the PR without knowing...

comment:9 Changed 6 years ago by Tillmann Karras

Owner: changed from avojnovicDk to Tillmann Karras

After talking with yamila-moreno, we agreed to have me finish this ticket. Sorry avojnovicDk, haven't heard anything from you, so I'll just change the owner (again).

comment:10 Changed 6 years ago by avojnovicDk

I just saw this. :) Yes, I am at DjangoUnderTheHood and was just working on this. I'll find something else to work on, no problem. It's great that the ticket is finished.

comment:11 Changed 6 years ago by Markus Holtermann

Triage Stage: AcceptedReady for checkin

comment:12 Changed 6 years ago by Tim Graham <timograham@…>

Resolution: fixed
Status: assignedclosed

In d18810131995dac63f9d89b0beaeadfc935130aa:

Fixed #23799 -- Made makemigrations respect --no-optimize.

Thanks to yamila-moreno for the idea of a skip message.

comment:13 Changed 6 years ago by Tim Graham <timograham@…>

In dfcac7d7f5f1f108ae2c561f0f755f08d75a1c27:

[1.7.x] Fixed #23799 -- Made makemigrations respect --no-optimize.

Thanks to yamila-moreno for the idea of a skip message.

Backport of d18810131995dac63f9d89b0beaeadfc935130aa from master

Note: See TracTickets for help on using tickets.
Back to Top