Error reporting docs needs to state clearly that changing logging conf error emails are not sent out unless configuring it again

[Peter Lauri]

Related documentation: ​https://docs.djangoproject.com/en/1.7/howto/error-reporting/

It states To activate this behavior, put the email addresses of the recipients in the ADMINS setting. and in the following See also it states that this behavior can be customized by changing logging.

The problem here is that a novice user will not easily catch that they break this behavior if they add their own LOGGING into settings.py without also adding the AdminEmailHandler handler and corresponding logger.

[Collin Anderson]

I could see slightly improved wording being helpful, though it would be nice to not increase the amount of text too much.

[Peter Novotnak]

documentation patch

[Peter Novotnak]

Does "0001-updated-error-reporting-documentation-as-per-ticket-.patch" work?

[Peter Lauri]

Maybe include a direct link to the AdminEmailHandler as well as complement to the reference to the logging configuration?

​https://docs.djangoproject.com/en/1.7/topics/logging/#django.utils.log.AdminEmailHandler

[Nathan Schagen]

​https://github.com/django/django/pull/4268

[Nathan Schagen]

According to django/conf/global_settings.py, LOGGING is an empty dictionary by default. There is also a DEFAULT_LOGGING in django/utils/log.py, which is where the default admin emailing behaviour is defined. DEFAULT_LOGGING and LOGGING are merged and therefore setting your own LOGGING conf does not break the email to admin feature.

I have tested this by installing a FileHandler in both DEFAULT_LOGGING and LOGGING and the message was written to both files.

[Peter Lauri]

Replying to nschagen:

According to django/conf/global_settings.py, LOGGING is an empty dictionary by default. There is also a DEFAULT_LOGGING in django/utils/log.py, which is where the default admin emailing behaviour is defined. DEFAULT_LOGGING and LOGGING are merged and therefore setting your own LOGGING conf does not break the email to admin feature.

I have tested this by installing a FileHandler in both DEFAULT_LOGGING and LOGGING and the message was written to both files.

Yes, I have read that. And I was not expecting admin email behaviour to break. But the below configuration breaks the admin email functionality, I have a test case where DEBUG=False and emails stop being sent. Removing the LOGGING completely OR re-adding mailadmin handler and logger makes it work again.

Can you share your LOGGING config?

LOGGING = {
    'version': 1,
    'disable_existing_loggers': False,
    'formatters': {
        'verbose': {
            'format': '%(levelname)s %(asctime)s %(module)s %(process)d %(thread)d %(message)s'
        },
        'simple': {
            'format': '%(levelname)s %(message)s'
        },
    },
    'handlers': {
        'console': {
            'class': 'logging.StreamHandler',
            'stream': sys.stdout,
            'formatter': 'simple'
        },
    },
    'loggers': {
        'django': {
            'handlers': ['console'],
            'level': 'INFO',
            'propagate': True,
        },
    }
}

[Peter Lauri]

You don't need to share your config, I get what you mean, had to read it again :)

But still it remains unclear why the above LOGGING conf breaks the email sending.

In my test case I use the in memory mail backend, and mails are not being sent anymore using the above configuration.