Changes between Version 3 and Version 4 of Ticket #23761
- Timestamp:
- Nov 4, 2014, 9:06:04 PM (10 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #23761 – Description
v3 v4 1 When implementing a custom field type with a db_type() method that returns None, on Django 1.6 and below we would signify not to create a column at all. 2 With Django 1.7, this causes a crash with the mysql backend. 3 The issue is already fixed in master and this simply backports the safety check. 4 1 5 A fix was made in August in master: 2 6 https://github.com/django/django/commit/e9103402c0fa873aea58a6a11dba510cd308cb84#diff-14 … … 4 8 The fix contains a lot more than is needed for this specific issue, however the specific changes to django/db/backends/mysql/validation.py would be great to have in Django 1.7. 5 9 6 When implementing a custom field type with a db_type() method that returns None, on Django 1.6 and below we would signify not to create a column at all.7 With Django 1.7, this causes a crash with the mysql backend.8 The issue is already fixed in master and this simply backports the safety check.9 10 10 This worked fine in < Django 1.7 and works fine in upstream.