Opened 10 years ago

Last modified 10 years ago

#23761 closed Bug

Mysql validator crashes with None db_type return. - Backport of master fix to 1.7 — at Version 4

Reported by: Adam DePue Owned by: nobody
Component: Core (System checks) Version: 1.7
Severity: Release blocker Keywords: mysql db_type
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Adam DePue)

When implementing a custom field type with a db_type() method that returns None, on Django 1.6 and below we would signify not to create a column at all.
With Django 1.7, this causes a crash with the mysql backend.
The issue is already fixed in master and this simply backports the safety check.

A fix was made in August in master:
https://github.com/django/django/commit/e9103402c0fa873aea58a6a11dba510cd308cb84#diff-14

The fix contains a lot more than is needed for this specific issue, however the specific changes to django/db/backends/mysql/validation.py would be great to have in Django 1.7.

This worked fine in < Django 1.7 and works fine in upstream.

Change History (4)

comment:1 by Adam DePue, 10 years ago

Last edited 10 years ago by Adam DePue (previous) (diff)

comment:2 by Adam DePue, 10 years ago

Component: UncategorizedCore (System checks)
Easy pickings: set

comment:3 by Adam DePue, 10 years ago

Description: modified (diff)

comment:4 by Adam DePue, 10 years ago

Description: modified (diff)
Note: See TracTickets for help on using tickets.
Back to Top