Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#23737 closed Cleanup/optimization (fixed)

RequestContext docs should recommend the render shortcut more clearly

Reported by: Aymeric Augustin Owned by: Tim Graham
Component: Documentation Version: 1.7
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

In https://docs.djangoproject.com/en/1.7/ref/templates/api/#subclassing-context-requestcontext, there's a note that starts with "If you’re using Django’s render_to_response() shortcut...".

It says "Alternatively, use the render() shortcut..." which is a rather half-hearted recommendation.

Everyone uses render() all the time and it's just fine. I suggest rewording that note or removing it.

Change History (4)

comment:1 Changed 5 years ago by Tim Graham

Owner: changed from nobody to Tim Graham
Status: newassigned
Triage Stage: UnreviewedAccepted

comment:2 Changed 5 years ago by Tim Graham <timograham@…>

Resolution: fixed
Status: assignedclosed

In f85fcc75e3c19d9694012afe97947d7b516d5dfc:

Fixed #23737 -- Recommended the render() shortcut more strongly.

Thanks Aymeric Augustin for the report.

comment:3 Changed 5 years ago by Tim Graham <timograham@…>

In de8825685491ed0e3078cdcef0f7fed7b08796cc:

[1.6.x] Fixed #23737 -- Recommended the render() shortcut more strongly.

Thanks Aymeric Augustin for the report.

Backport of f85fcc75e3 from master

comment:4 Changed 5 years ago by Tim Graham <timograham@…>

In 01119c9c0f17387d2046bbd700835d85330d5151:

[1.7.x] Fixed #23737 -- Recommended the render() shortcut more strongly.

Thanks Aymeric Augustin for the report.

Backport of f85fcc75e3 from master

Note: See TracTickets for help on using tickets.
Back to Top