Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#23705 closed Cleanup/optimization (fixed)

mod_wsgi deployment documentation includes unncessary AliasMatch

Reported by: Keryn Knight Owned by: Tim Graham
Component: Documentation Version: dev
Severity: Normal Keywords:
Cc: django@… Triage Stage: Ready for checkin
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

This line in the docs appears to be a remnant of the time before staticfiles:

AliasMatch ^/([^/]*\.css) /path/to/mysite.com/static/styles/$1

which as far as I understand it, is to allow domain-root-relative CSS files to be point through to staticfiles collectstatic output.
Off the top of my head, this seems like it would sidestep using {% static "file.css" %} (which would still work) and is not required in any sane/tidy configuration [and probably makes it harder to load those files in the dev server by virtue of needing another urlconf pattern].
It additionally has the burden of implying that static/styles exists, or is the only place CSS files could reside [the static/styles path is *only* mentioned in that AliasMatch]

It looks like the commit that introduced it was 9fd19c01611e5ed1ed64bbeb462ab96499d72a6c, in the 1.1 days. Two tickets have existed: #13912 and #11229, also both back in the pre-staticfiles days. It appears to have just been carried forward across renames accidentally, IMHO, and I can't think of a great reason for it being there.

Change History (4)

comment:1 by Tim Graham, 10 years ago

Owner: changed from nobody to Tim Graham
Status: newassigned
Triage Stage: UnreviewedReady for checkin

comment:2 by Tim Graham <timograham@…>, 10 years ago

Resolution: fixed
Status: assignedclosed

In 4b0a45ce64bfa1ce39d963738ffb0af57f4517e5:

Fixed #23705 -- Removed unnecessary AliasMatch from example Apache config.

Thanks Keryn Knight for the report.

comment:3 by Tim Graham <timograham@…>, 10 years ago

In ba6a599ce4e363cdce2d4cc439ce57436fb194fb:

[1.7.x] Fixed #23705 -- Removed unnecessary AliasMatch from example Apache config.

Thanks Keryn Knight for the report.

Backport of 4b0a45ce64 from master

comment:4 by Tim Graham <timograham@…>, 10 years ago

In b087d9b5e6e16a8135e09adf8386e34fbb64d046:

[1.6.x] Fixed #23705 -- Removed unnecessary AliasMatch from example Apache config.

Thanks Keryn Knight for the report.

Backport of 4b0a45ce64 from master

Note: See TracTickets for help on using tickets.
Back to Top