Opened 10 years ago
Closed 10 years ago
#23659 closed Bug (fixed)
Lost annotation ordering with values_list() and annotate()
Reported by: | Claude Paroz | Owned by: | nobody |
---|---|---|---|
Component: | Database layer (models, ORM) | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Ready for checkin | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
When I'm aggregating with values_list()
and then annotate with a list of clauses, I'd expect the annotate *args ordering to be respected in the resulting lists. Unfortunately, annotate()
args ordering is currently discarded because all annotations parameters are consolidated in a plain dict
.
Change History (6)
comment:1 by , 10 years ago
Has patch: | set |
---|
comment:2 by , 10 years ago
Triage Stage: | Unreviewed → Ready for checkin |
---|---|
Version: | 1.7 → master |
It's also what I would expect from values_list()
and annotate()
chaining.
Patch LGTM, CI failures look unrelated.
comment:3 by , 10 years ago
Triage Stage: | Ready for checkin → Accepted |
---|
Loïc raised an issue on the PR that must be addressed before merging.
comment:5 by , 10 years ago
Triage Stage: | Accepted → Ready for checkin |
---|
Except the two flake8 warnings the patch is RFC.
comment:6 by , 10 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
https://github.com/django/django/pull/3371