Opened 10 years ago
Closed 10 years ago
#23652 closed Bug (fixed)
Database name is not reset after destroying test database
| Reported by: | Bjarkias | Owned by: | nobody |
|---|---|---|---|
| Component: | Testing framework | Version: | 1.7 |
| Severity: | Normal | Keywords: | test destroy_test_db |
| Cc: | Claude Paroz | Triage Stage: | Ready for checkin |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description (last modified by )
When using connection.creation.destroy_test_db(old_db_name) the settings.DATABASES default name isn't reset to old_db_name like described in in docshttps://docs.djangoproject.com/en/1.6/topics/testing/advanced/#django.db.connection.creation.destroy_test_db.
Change History (7)
comment:1 by , 10 years ago
| Description: | modified (diff) |
|---|
comment:2 by , 10 years ago
| Type: | Uncategorized → Bug |
|---|
comment:3 by , 10 years ago
| Cc: | added |
|---|---|
| Triage Stage: | Unreviewed → Accepted |
| Version: | 1.6 → 1.7 |
comment:4 by , 10 years ago
In my commit, I just removed the NAME attribution in a copied dict. Probably the real commit that changed this is https://github.com/django/django/commit/f1dc83cb9877d349df88674a0752ddf42657485b#diff-f0b4f23d2d3eab42aeb0ff91a1b4d9f7L322
So yes, restoring the original database name is currently missing.
comment:6 by , 10 years ago
| Triage Stage: | Accepted → Ready for checkin |
|---|
comment:7 by , 10 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
Behavior changed in e953c78eeb81ee69dccd356145563fd6f9e4c7b6 (1.7). Claude, I wonder what you think we should do? I'm not sure if we should update the documentation or the code.