Doc error in RegexValidator.regex

[Claude Paroz]

In ​https://docs.djangoproject.com/fr/1.7/ref/validators/#django.core.validators.RegexValidator.regex, I think that the effects of inverse_match are reversed. A ValidationError is raised when inverse_match=True and a match is found. Can someone confirm? Boolean logic, we love you!

[Baptiste Mispelon]

Hi,

You're right (and I also find this sentence really hard to parse, but maybe that's just me):

>>> RegexValidator(regex='[a-z]')('1')
Traceback (most recent call last):
  File "<console>", line 1, in <module>
  File "/home/tisba/Programming/testbed/boogz/django/core/validators.py", line 51, in __call__
    raise ValidationError(self.message, code=self.code)
django.core.exceptions.ValidationError: ['Enter a valid value.']
>>> RegexValidator(regex='[a-z]', inverse_match=True)('1')

I wouldn't be opposed to a rewrite of this paragraph since I find it quite confusing.

[Claude Paroz]

Suggested patch:

docs/ref/validators.txt

@@ -81 +81 @@
     .. attribute:: regex
 
         The regular expression pattern to search for the provided ``value``,
-        or a pre-compiled regular expression. Raises a
+        or a pre-compiled regular expression. By default, raises a
         :exc:`~django.core.exceptions.ValidationError` with :attr:`message`
-        and :attr:`code` if :attr:`inverse_match` is ``False`` and a match is
-        found, or if :attr:`inverse_match` is ``True`` and a match is not found.
-        By default, matches any string (including an empty string).
+        and :attr:`code` if a match is not found. That standard behavior might
+        be reversed by setting :attr:`inverse_match` to ``True``, meaning that
+        the :exc:`~django.core.exceptions.ValidationError` is raised when a
+        match **is** found. By default, matches any string (including an empty
+        string).
 
     .. attribute:: message

[doriczapari]

Here's the pull request: ​https://github.com/django/django/pull/3346

[Baptiste Mispelon <bmispelon@…>]

In c48a29a02a457cfdb1cff11009401459ba24e870:

Fixed #23639 -- Fixed doc error in RegexValidator.regex

Thanks to @claudep for the report and the original patch.

[Baptiste Mispelon <bmispelon@…>]

In d2a2af67f7c2c41a831acd33cd8cba5875c216cf:

[1.7.x] Fixed #23639 -- Fixed doc error in RegexValidator.regex

Thanks to @claudep for the report and the original patch.

Backport of c48a29a02a457cfdb1cff11009401459ba24e870 from master.