Opened 10 years ago

Closed 10 years ago

Last modified 9 years ago

#23613 closed Cleanup/optimization (fixed)

django.utils.checksums is undocumented and unused

Reported by: Aymeric Augustin Owned by: nobody
Component: Utilities Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

This module provides a single function that implements the Luhn algorithm. It isn't documented and it isn't imported except in its own tests.

I suspect it was used by django.contrib.localflavor and left behind when that application was split from Django. It should be moved to django-localflavor, shouldn't it?

Change History (7)

comment:1 by Tim Graham, 10 years ago

Triage Stage: Unreviewed → Accepted

Looks good to me. We need a PR to update ​https://github.com/django/django-localflavor and then go through the deprecation in Django I suppose.

comment:2 by Jaap Roes, 10 years ago

I've created a pull request for django-localflavor (​https://github.com/django/django-localflavor/pull/122)

comment:3 by Jaap Roes, 10 years ago

Assuming the pull requests goes through, the removal will take place in Django 2.0 right?

comment:4 by Tim Graham, 10 years ago

Yes, see the guide on ​deprecating a feature if you haven't.

comment:5 by Jaap Roes, 10 years ago

Has patch: set

comment:6 by Tim Graham <timograham@…>, 10 years ago

Resolution: → fixed
Status: new → closed

In 115c307184d441fbc27a8f43a99af5d992cfcc13:

Fixed #23613 -- Deprecated django.utils.checksums

comment:7 by Tim Graham <timograham@…>, 9 years ago

In e5c12f67:

Refs #23613 -- Removed django.utils.checksums per deprecation timeline.

Note: See TracTickets for help on using tickets.
Back to Top