Opened 8 years ago

Closed 8 years ago

#23600 closed Bug (fixed)

Overriding several settings is ignored by default_storage.

Reported by: Duncan Parkes Owned by: Duncan Parkes
Component: File uploads/storage Version: dev
Severity: Normal Keywords: testing override_settings
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

django.core.files.storage.default_storage keeps a local copy of, and doesn't take account of changes to, the following settings:

MEDIA_URL
FILE_UPLOAD_PERMISSIONS
FILE_UPLOAD_DIRECTORY_PERMISSIONS

This is the problem noted and fixed in #17744 for MEDIA_ROOT and noted in general in #17787.

Change History (6)

comment:1 Changed 8 years ago by Duncan Parkes

Owner: changed from nobody to Duncan Parkes
Status: newassigned

comment:2 Changed 8 years ago by Duncan Parkes

I have a branch ready to pull request for this, but GitHub is misbehaving for me right now.

comment:3 Changed 8 years ago by Duncan Parkes

comment:4 Changed 8 years ago by Collin Anderson

Triage Stage: UnreviewedAccepted

comment:5 Changed 8 years ago by Tim Graham

Patch needs improvement: set

Left comments for improvement on the PR.

comment:6 Changed 8 years ago by Tim Graham <timograham@…>

Resolution: fixed
Status: assignedclosed

In 88b6cf4ae41a983bda735a5f61f69f6b1482e2ca:

Fixed #23600 -- Made default_storage aware of more settings changes.

Added MEDIA_URL, FILE_UPLOAD_PERMISSIONS, and
FILE_UPLOAD_DIRECTORY_PERMISSIONS to the list of settings.

Note: See TracTickets for help on using tickets.
Back to Top