#23583 closed Bug (fixed)
makemessages for javascript no longer works
| Reported by: | Michal Čihař | Owned by: | Claude Paroz |
|---|---|---|---|
| Component: | Internationalization | Version: | 1.7 |
| Severity: | Release blocker | Keywords: | |
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description (last modified by )
makemessages ignores any in-app paths that begin with static because of this line:
https://github.com/django/django/blob/master/django/core/management/commands/makemessages.py#L233
it should ignore something like "<path>/*" but not "<path>*"
reproducible:
https://github.com/blodone/django_static_broken
Change History (10)
comment:1 Changed 9 years ago by
comment:2 Changed 9 years ago by
| Resolution: | → invalid |
|---|---|
| Status: | new → closed |
STATIC_ROOT is not supposed to point to where your static files are located in your source code, but where you deploy them. I think you might be misusing the static files framework.
https://docs.djangoproject.com/en/1.7/ref/settings/#std:setting-STATIC_ROOT
comment:3 Changed 9 years ago by
| Description: | modified (diff) |
|---|---|
| Has patch: | unset |
| Resolution: | invalid |
| Status: | closed → new |
comment:4 Changed 9 years ago by
| Component: | Translations → Internationalization |
|---|---|
| Has patch: | set |
| Owner: | changed from nobody to Claude Paroz |
| Patch needs improvement: | set |
| Severity: | Normal → Release blocker |
| Status: | new → assigned |
| Triage Stage: | Unreviewed → Accepted |
comment:5 Changed 9 years ago by
| Patch needs improvement: | unset |
|---|
Alternative patch: https://github.com/django/django/pull/3386
Review welcome (possibly on Windows). This is a candidate for 1.7.1.
comment:6 Changed 9 years ago by
| Triage Stage: | Accepted → Ready for checkin |
|---|
comment:7 Changed 9 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
comment:9 Changed 9 years ago by
If STATIC_ROOT is None (which is the default), makemessages raises AttributeError. This bug was introduced with Django 1.7.1. In Django 1.7 it is not there.
comment:10 Changed 9 years ago by
normanjaeckel, please go ahead and open a new release blocker ticket referring to this one to make sure we release 1.7.2 with the appropriate fix.
Pull request: https://github.com/django/django/pull/3298