Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#23583 closed Bug (fixed)

makemessages for javascript no longer works

Reported by: Michal Čihař Owned by: Claude Paroz
Component: Internationalization Version: 1.7
Severity: Release blocker Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by blodone)

makemessages ignores any in-app paths that begin with static because of this line:
https://github.com/django/django/blob/master/django/core/management/commands/makemessages.py#L233

it should ignore something like "<path>/*" but not "<path>*"

reproducible:
https://github.com/blodone/django_static_broken

Change History (10)

comment:1 Changed 4 years ago by Michal Čihař

comment:2 Changed 4 years ago by Claude Paroz

Resolution: invalid
Status: newclosed

STATIC_ROOT is not supposed to point to where your static files are located in your source code, but where you deploy them. I think you might be misusing the static files framework.
https://docs.djangoproject.com/en/1.7/ref/settings/#std:setting-STATIC_ROOT

comment:3 Changed 4 years ago by blodone

Description: modified (diff)
Has patch: unset
Resolution: invalid
Status: closednew

comment:4 Changed 4 years ago by Claude Paroz

Component: TranslationsInternationalization
Has patch: set
Owner: changed from nobody to Claude Paroz
Patch needs improvement: set
Severity: NormalRelease blocker
Status: newassigned
Triage Stage: UnreviewedAccepted

comment:5 Changed 4 years ago by Claude Paroz

Patch needs improvement: unset

Alternative patch: https://github.com/django/django/pull/3386
Review welcome (possibly on Windows). This is a candidate for 1.7.1.

comment:6 Changed 4 years ago by Tim Graham

Triage Stage: AcceptedReady for checkin

comment:7 Changed 4 years ago by Claude Paroz <claude@…>

Resolution: fixed
Status: assignedclosed

In 8b4cc9df9c0760eb4896f1423b6119bdad5674c6:

Fixed #23583 -- More selectively ignored static/media roots

Fixed a regression introduced by 28efafa24c.
Thanks Michal Čihař for the report and initial patch, and
Collin Anderson and Tim Graham for the reviews.

comment:8 Changed 4 years ago by Claude Paroz <claude@…>

In d5a273eadb00ee3edd7e81d373b7237220b42571:

[1.7.x] Fixed #23583 -- More selectively ignored static/media roots

Fixed a regression introduced by 28efafa24c.
Thanks Michal Čihař for the report and initial patch, and
Collin Anderson and Tim Graham for the reviews.
Backport of 8b4cc9df9c from master.

comment:9 Changed 4 years ago by Norman Jäckel

If STATIC_ROOT is None (which is the default), makemessages raises AttributeError. This bug was introduced with Django 1.7.1. In Django 1.7 it is not there.

comment:10 Changed 4 years ago by Simon Charette

normanjaeckel, please go ahead and open a new release blocker ticket referring to this one to make sure we release 1.7.2 with the appropriate fix.

Note: See TracTickets for help on using tickets.
Back to Top