Opened 10 years ago
Closed 10 years ago
#23566 closed Bug (duplicate)
Incorrect timezone handling in feed community blog post aggregator?
Reported by: | FoxMaSk | Owned by: | nobody |
---|---|---|---|
Component: | *.djangoproject.com | Version: | |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Accepted | |
Has patch: | no | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
Hi,
I made a tools that grab data from Feeds and put them to others service (like Evernote in my case)
And I think I spotted an issue with the RSS Feeds on https://www.djangoproject.com/community/ the "Community blog posts" part (may be the others are impacted but I didnt check). The date of the feeds is updated but the provider of the feeds did not change anything.
For example, the current last post is on "Community blog posts":
on https://www.vlent.nl/weblog/feed.atom ; its last post has :
<id>tag:www.vlent.nl,2014-09-28:/weblog/2014/09/28/how-we-use-virtualenv-buildout-and-docker/</id>
<updated>2014-09-28T21:53:00Z</updated>
But on https://www.djangoproject.com/community/ the Feeds tell us :
<lastBuildDate>Sun, 28 Sep 2014 21:53:00 -0500</lastBuildDate>
As my batch works each hour from a crontab, I received this "news" more than once.
It looks like this is the last build date of the entire Feeds "Community blog posts" itself, but not the last update of the provider source https://www.vlent.nl/weblog/feed.atom.
Regards
Change History (6)
comment:1 by , 10 years ago
comment:2 by , 10 years ago
Hi,
the two date are different as one of them use a TIMEZONE (-0500) and not the second one. I'm not a datetime expert but may be this should be handle in the piece of code you linked above ?
comment:3 by , 10 years ago
Summary: | On "Community blog posts" Feeds RSS updated for nothing → Incorrect timezone handling in feed community blog post aggregator? |
---|---|
Triage Stage: | Unreviewed → Accepted |
Type: | Uncategorized → Bug |
Version: | 1.7 |
I guess we have timezone issues in the feed_updated()
function of the models.py file here: https://github.com/django/djangoproject.com/tree/master/aggregator.
comment:4 by , 10 years ago
from the models.py I see here https://github.com/django/djangoproject.com/blob/master/aggregator/models.py#L159-164, on my side, I had to do this to handle the same behavior https://github.com/foxmask/django-th/blob/master/django_th/management/commands/fire_th.py#L36-43 but without dropping the end of the date (by using [:6] if 'im not wrong) makes more problem than it solves them.
comment:6 by , 10 years ago
Resolution: | → duplicate |
---|---|
Status: | new → closed |
Here is the logic for how the feed's
lastBuildDate
is generated: https://github.com/django/django/blob/fe2afcd318493c933ab1191a5a64271869a1227f/django/utils/feedgenerator.py#L194-L209I don't understand the issue. It looks like the two dates in your example above are the same?