Opened 8 years ago

Closed 8 years ago

#23540 closed Uncategorized (duplicate)

RunSQL Bug Django 1.7

Reported by: Aryeh Hillman Owned by: nobody
Component: Migrations Version: 1.7
Severity: Normal Keywords: migrations runsql postgresql
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Django migrations are wonderful, but I have found a bug. Here's how to reproduce (there is probably a more minimal case):

  1. Install this function at a shell for PostgreSQL

`CREATE FUNCTION exec(text) returns text language plpgsql volatile

AS $f$

BEGIN

EXECUTE $1;
RETURN $1;

END;

$f$;`

source: http://wiki.postgresql.org/wiki/Dynamic_DDL

  1. Write a RunSQL operation to help rename some tables

`class Migration(migrations.Migration):
...

operations = [

migrations.RunPython(

code=x

),
migrations.RunSQL(

sql="""select exec(format('alter table %I rename to %I', tablename, regexp_replace(tablename, 'hello, 'goodbye'))) from pg_tables where tablename like 'hello%';"""

),

]`

  1. Run the migration. I got this error:

`Traceback (most recent call last):

File "./manage.py", line 10, in <module>

execute_from_command_line(sys.argv)

File "/Users/abhillman/stable_env/lib/python2.7/site-packages/django/core/management/init.py", line 385, in execute_from_command_line

utility.execute()

File "/Users/abhillman/stable_env/lib/python2.7/site-packages/django/core/management/init.py", line 377, in execute

self.fetch_command(subcommand).run_from_argv(self.argv)

File "/Users/abhillman/stable_env/lib/python2.7/site-packages/django/core/management/base.py", line 288, in run_from_argv

self.execute(*args, options.dict)

File "/Users/abhillman/stable_env/lib/python2.7/site-packages/django/core/management/base.py", line 338, in execute

output = self.handle(*args, options)

File "/Users/abhillman/stable_env/lib/python2.7/site-packages/django/core/management/commands/migrate.py", line 160, in handle

executor.migrate(targets, plan, fake=options.get("fake", False))

File "/Users/abhillman/stable_env/lib/python2.7/site-packages/django/db/migrations/executor.py", line 63, in migrate

self.apply_migration(migration, fake=fake)

File "/Users/abhillman/stable_env/lib/python2.7/site-packages/django/db/migrations/executor.py", line 97, in apply_migration

migration.apply(project_state, schema_editor)

File "/Users/abhillman/stable_env/lib/python2.7/site-packages/django/db/migrations/migration.py", line 107, in apply

operation.database_forwards(self.app_label, schema_editor, project_state, new_state)

File "/Users/abhillman/stable_env/lib/python2.7/site-packages/django/db/migrations/operations/special.py", line 69, in database_forwards

schema_editor.execute(statement)

File "/Users/abhillman/stable_env/lib/python2.7/site-packages/django/db/backends/schema.py", line 98, in execute

cursor.execute(sql, params)

File "/Users/abhillman/stable_env/lib/python2.7/site-packages/django/db/backends/utils.py", line 81, in execute

return super(CursorDebugWrapper, self).execute(sql, params)

File "/Users/abhillman/stable_env/lib/python2.7/site-packages/django/db/backends/utils.py", line 65, in execute

return self.cursor.execute(sql, params)

IndexError: list index out of range`

Not sure what's going on here. Could it be the custom function?

Change History (1)

comment:1 Changed 8 years ago by Aryeh Hillman

Resolution: duplicate
Status: newclosed
Note: See TracTickets for help on using tickets.
Back to Top