Opened 10 years ago
Closed 10 years ago
#23466 closed Cleanup/optimization (fixed)
Removing seconds from locale formats
Reported by: | Malte Beckmann | Owned by: | nobody |
---|---|---|---|
Component: | Internationalization | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Accepted | |
Has patch: | yes | Needs documentation: | yes |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description (last modified by )
As discussed on the Django-developers mailing list (Subject: Unifying locale time formats).
I propose the removal of seconds from standard time output formats.
Here it is: https://github.com/maltebeckmann/django/tree/ticket_23466
Change History (10)
comment:1 by , 10 years ago
Component: | Translations → Internationalization |
---|---|
Triage Stage: | Unreviewed → Accepted |
Version: | 1.6 → master |
comment:2 by , 10 years ago
Description: | modified (diff) |
---|
comment:3 by , 10 years ago
Description: | modified (diff) |
---|
comment:4 by , 10 years ago
comment:6 by , 10 years ago
@Claude
Created the pull request: https://github.com/django/django/pull/3218 (took me a bit, still new to this process).
@Wim
I also noticed a number of issues in regard to uniformity of times and dates. I am, however, wondering whether there is the odd locale in which time does require a leading zero. Either way, I think there are lots of inconsistencies that should be addressed. But I think this needs to be addressed in another ticket.
comment:7 by , 10 years ago
Has patch: | set |
---|---|
Needs documentation: | set |
Thanks, the patch is fine. Now only a release note is missing.
comment:9 by , 10 years ago
Yes it is :-) See docs/releases/1.8.txt
. A good Django patch has usually both tests and docs. In this specific case, tests are not so useful.
comment:10 by , 10 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Hi, nice work!
Let's mention this change in the release notes! :)
under Internationalization:
"Removed seconds in locale time formats."
or something like that.
Can you do that please?
In addition, I was wondering whether we should unify G:i and H:i (hours with or without leading zeros). I'll ask on the mailing list.