Opened 10 years ago
Closed 10 years ago
#23450 closed Bug (fixed)
Transient failure of requests.tests.RequestsTests.test_far_expiration
Reported by: | Simon Charette | Owned by: | Paweł Marczewski |
---|---|---|---|
Component: | Testing framework | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | pwmarcz@… | Triage Stage: | Accepted |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | yes | UI/UX: | no |
Description
Traceback (most recent call last): File "/home/jenkins/workspace/django-master/database/mysql/python/python2.7/tests/requests/tests.py", line 178, in test_far_expiration self.assertEqual(datetime_cookie['expires'], 'Sat, 01-Jan-2028 04:05:06 GMT') AssertionError: u'Sat, 01-Jan-2028 04:05:07 GMT' != u'Sat, 01-Jan-2028 04:05:06 GMT' - Sat, 01-Jan-2028 04:05:07 GMT ? ^ + Sat, 01-Jan-2028 04:05:06 GMT ? ^
Attachments (1)
Change History (8)
comment:1 by , 10 years ago
Triage Stage: | Unreviewed → Accepted |
---|
comment:2 by , 10 years ago
comment:3 by , 10 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:4 by , 10 years ago
Cc: | added |
---|---|
Has patch: | set |
comment:5 by , 10 years ago
Patch needs improvement: | set |
---|
I left comments for improvement on the PR. Please uncheck "Patch needs improvement" when you update it, thanks.
by , 10 years ago
Attachment: | 23450.diff added |
---|
comment:6 by , 10 years ago
Patch needs improvement: | unset |
---|
Attached a patch to admit n+1 seconds as suggested by Claude.
comment:7 by , 10 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Note:
See TracTickets
for help on using tickets.
This is probably related to this part of
django/http/response.py
:The test should admit n+1 second too, IMHO.