Incorrect parameter coercion for bool in Oracle backend

[Josh Smeaton]

The following code exists in backends.oracle.base.OracleParam:

        # Oracle doesn't recognize True and False correctly in Python 3.
        # The conversion done below works both in 2 and 3.
        if param is True:
            param = "1"
        elif param is False:
            param = "0"

I believe the conversion should be to the integers 1 and 0 respectively, rather than strings. This hasn't manifested as a problem before, but it is causing problems when using user defined boolean annotations in #14030. The string "1" is being returned rather than the integer 1 so the field converters aren't receiving the type they expect (integers) and do no conversions.

The alternative to changing the code above would be to change the field converter to check for value in ("1","0") and then do the relevant bool(int()) conversion, but I think that's working around the actual problem.

Happy to put a patch together. I just wanted to get some buy in that this needs fixing first, and that the approach above should be valid. I'm not sure whether OracleParam can work with just strings or not.

[Josh Smeaton]

​https://github.com/django/django/pull/3190

[Tim Graham]

Original code added by Anssi in [4db38cbf]. Hopefully he can either +1 this or say why it's wrong.

[Anssi Kääriäinen]

I don't recall why I used strings. As Oracle uses Number(1, 0) for BooleanFields, using 1 and 0 seems like the right choice here. +1

[Tim Graham <timograham@…>]

In 638d1393eebfdd4ae360cf1b279d4a0c3072aba5:

Fixed #23434 -- Coerce Oracle bool params to int