Opened 10 years ago
Closed 8 years ago
#23425 closed Cleanup/optimization (invalid)
Hide oracle specific GIS behaviour behind a feature flag
Reported by: | Josh Smeaton | Owned by: | nobody |
---|---|---|---|
Component: | GIS | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Accepted | |
Has patch: | no | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
There are several places where oracle is singled out in GIS. These checks should probably be pushed down into feature flags.
Some examples:
# GeoAggregate.as_sql if connection.ops.oracle: self.extra['tolerance'] = self.tolerance
# GeoQuery.get_aggregation if isinstance(aggregate, gis_aggregates.GeoAggregate): if not getattr(aggregate, 'is_extent', False) or connection.ops.oracle: self.extra_select_fields[alias] = GeomField()
Change History (2)
comment:1 by , 10 years ago
Triage Stage: | Unreviewed → Accepted |
---|
comment:2 by , 8 years ago
Resolution: | → invalid |
---|---|
Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
git grep ops.oracle
gives no results, so this ticket doesn't seem to be actual anymore.