makemigrations doesn't use --noinput

[Baptiste Mispelon]

#22862 added the --noinput to the makemigrations command but only when using --merge.

It seems to me that it would be a useful addition to the plain makemigrations too and could work like this:

• If the migrations can be created without user input, create it
• If not, raise an error.

I tried changing the code to use MigrationQuestioner instead of InteractiveMigrationQuestioner but it seems that this just creates a migration with default=None which might not be what you want.

Implementing a new questioner object like this seems to work in my limited testcase:

class NonInteractiveQuestioner(MigrationQuestioner):
    def ask_not_null_addition(self, field_name, model_name):
        raise NotImplementedError

    def ask_rename(self, model_name, old_name, new_name, field_instance):
        raise NotImplementedError

    def ask_rename_model(self, old_model_state, new_model_state):
        raise NotImplementedError

    def ask_merge(self, app_label):
        raise NotImplementedError

[Baptiste Mispelon]

I'll also note that the current documentation for makemigrations [1] is incorrect since it states:

The --noinput option may be provided to suppress all user prompts.

Which is incorrect.

[1] ​https://docs.djangoproject.com/en/1.7/ref/django-admin/#django-admin-makemigrations

[Tim Graham]

If we don't choose to backport the fix to 1.7, we should correct the documentation.

[Andrew Godwin]

Agree that implementing a new questioner is the best way, though I think some of the questions we can give sensible answers to (e.g. rename, rename_model should probably just be False as rename detection is not guaranteed anyway)

[Tim Graham <timograham@…>]

In 450a61600407d7320b85b75b441ce67b199da68b:

Corrected --noinput docs for makemigrations; refs #23407.

[Tim Graham <timograham@…>]

In 40e5eb4114e66dfaacea162fc9f39c0618dcfad9:

[1.7.x] Corrected --noinput docs for makemigrations; refs #23407.

Backport of 450a616004 from master

[karyon]

there is also "manage.py makemigrations --help" which tells the user

"--noinput             Tells Django to NOT prompt the user for input of any kind."

[Marten Kenbeek]

PR: ​https://github.com/django/django/pull/4261

[Markus Holtermann <info@…>]

In e272904ff7cc4d138e316ba2e7811666053860a4:

Fixed #23407 -- Extended coverage of makemigrations --noinput option.

Changed --noinput option in makemigrations to suppress all user prompts,
not just when combined with --merge.