Opened 12 months ago

Closed 4 months ago

#23387 closed Bug (fixed)

Error when saving inline formsets as new after a validation error.

Reported by: johnrtipton Owned by: adamzap
Component: contrib.admin Version: master
Severity: Normal Keywords: admin formset validation base10
Cc: karnatijayadeep@… Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description (last modified by johnrtipton)

This bug seems to have been around for a long time, as I've tried this from version 1.4 up.

While in the admin, if you have a form with inline formsets and you try to do a save as new, it works properly, unless there is a validation error. If you get a validation error, Django sends you through the add_view which no longer has the "Save as new" option. If you click save here, you will get the error below:

ValueError at /admin/drawings/sow/add/
invalid literal for int() with base 10:
Request Method: POST
Request URL: http://127.0.0.1:8000/admin/drawings/sow/add/
Django Version: 1.6.6.dev20140829183230
Exception Type: ValueError
Exception Value:
invalid literal for int() with base 10:

Exception Location: /Users/tip/Dropbox/websites/isotekrms/django/db/models/fields/init.py in get_prep_value, line 613
Python Executable: /System/Library/Frameworks/Python.framework/Versions/2.7/Resources/Python.app/Contents/MacOS/Python
Python Version: 2.7.6

I, have written a small patch that will check to see if the formset had validation errors and it was submitted as a save as new, it will set the context variable change=True which causes the "Save as new" button to show on the form again. Fixing the validation errors on the screen and pressing "Save as new" again will save the form properly.

Attachments (3)

formset_save_as_validation.patch (637 bytes) - added by johnrtipton 12 months ago.
Patch
formset_save_as_validation.2.patch (666 bytes) - added by johnrtipton 12 months ago.
Updated Patch.
formset_save_as_validation.3.patch (2.2 KB) - added by johnrtipton 11 months ago.

Download all attachments as: .zip

Change History (20)

Changed 12 months ago by johnrtipton

Patch

comment:1 Changed 12 months ago by johnrtipton

  • Easy pickings set
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

Changed 12 months ago by johnrtipton

Updated Patch.

comment:2 Changed 12 months ago by johnrtipton

  • Description modified (diff)

comment:3 Changed 12 months ago by timgraham

  • Needs tests set
  • Triage Stage changed from Unreviewed to Accepted

The patch also requires tests.

comment:4 Changed 11 months ago by raulcd

  • Owner changed from nobody to raulcd
  • Status changed from new to assigned

Changed 11 months ago by johnrtipton

comment:5 Changed 11 months ago by johnrtipton

Updated patch to hide "Save" and "Save and Continue" buttons after a validation error when try to Save as New.

If you try to Save as New and get a validation error, you must hit Save as New again or you will get the previously mentioned error.

comment:6 Changed 9 months ago by raulcd

  • Owner raulcd deleted
  • Status changed from assigned to new

comment:7 Changed 8 months ago by jayadeepk

  • Cc karnatijayadeep@… added
  • Owner set to jayadeepk
  • Status changed from new to assigned
  • Version changed from 1.6 to master

The bug is reproducible in master version.

comment:8 Changed 6 months ago by tino

  • Owner changed from jayadeepk to tino

comment:9 Changed 6 months ago by tino

There is a problem with "Save as new" and validation errors in general. When you click "Save as new" and a validation error is raised, the ModelAdmin.add_view is returned, which does not include the "Save as new" button, but the other save buttons. The url is still the change url of the original object. This is confusing, as all the normal save buttons work as "Save as new" buttons now.

I would suggest that in that case, we should only show the "Save as new" button, and hide the others, as was proposed earlier in this patch.

If we would have to go in the direction to keep the other save buttons (and the "Save as new" button, all with correct functionality), the fix for the underlying issue with the inline formsets is not easy. You would have to validate both the object and it's inline instances (https://github.com/django/django/blob/master/django/contrib/admin/options.py#L1367), and if either fails, reset the inline instances to instances where save_as_new is False.

comment:10 Changed 6 months ago by tino

  • Needs tests unset

All right, created a pull request in the direction that the original author took: https://github.com/django/django/pull/4265

comment:11 Changed 5 months ago by timgraham

  • Patch needs improvement set

PR reviewed.

comment:12 Changed 5 months ago by adamzap

tino, I'd be happy to address Tim's comments on your pull request and finish the ticket if you don't have the time right now.

comment:13 Changed 4 months ago by adamzap

  • Owner changed from tino to adamzap

comment:14 Changed 4 months ago by adamzap

I submitted a new pull request that addresses Tim's comments: https://github.com/django/django/pull/4559

comment:15 Changed 4 months ago by timgraham

  • Patch needs improvement unset

comment:16 Changed 4 months ago by timgraham

  • Triage Stage changed from Accepted to Ready for checkin

comment:17 Changed 4 months ago by Tim Graham <timograham@…>

  • Resolution set to fixed
  • Status changed from assigned to closed

In 0894643e:

Fixed #23387 -- Kept "Save as new" button after validation errors in admin.

When "Save as new" is chosen and errors occur, only show the "Save as new"
button and not the other save buttons.

Thanks to Tino de Bruijn for doing the real work on this fix.

Note: See TracTickets for help on using tickets.
Back to Top