Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#23384 closed New feature (wontfix)

Allow overriding part of a dictionary-type setting

Reported by: Claude Paroz Owned by: nobody
Component: Core (Other) Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no
Pull Requests:3138 unmerged

Description

This issue has been discussed as part of two new upcoming changes related to settings:
#22734 Move SMTP / email settings to a dictionary
and
#17101 Add "checkdeploy" management command

where it was desired that related settings could be grouped in a parent dictionary.
The idea is that the user shouldn't then mandatorily define all setting keys to only change some of them.

Change History (5)

comment:1 by Claude Paroz, 11 years ago

Has patch: set

Pull request: ​https://github.com/django/django/pull/3138

comment:2 by Tim Graham, 11 years ago

Triage Stage: Unreviewed → Ready for checkin

comment:3 by Claude Paroz <claude@…>, 11 years ago

Resolution: → fixed
Status: new → closed

In 66757fee7e921ad4c35e0b3f80c25e026100b31c:

Fixed #23384 -- Allowed overriding part of a dictionary-type setting

This change is needed for upcoming changes where settings might be
grouped in a parent dictionary.
Thanks Tim Graham for the review.

comment:4 by Claude Paroz <claude@…>, 11 years ago

In 885ff6845e54511022677c1f28b84ddd4f2165dd:

Revert "Fixed #23384 -- Allowed overriding part of a dictionary-type setting"

This reverts commit 66757fee7e921ad4c35e0b3f80c25e026100b31c.
Discussions have led to think that this functionality does not
bring significant benefits to justify the added complexity.
Read also discussions on ticket #22734.

comment:5 by Claude Paroz, 11 years ago

Resolution: fixed → wontfix
Note: See TracTickets for help on using tickets.
Back to Top