#23374 closed Cleanup/optimization (fixed)
django.contrib.staticfiles.testing.StaticLiveServerCase should be named StaticLiveServerTestCase
| Reported by: | Raphaël Hertzog | Owned by: | Claude Paroz |
|---|---|---|---|
| Component: | contrib.staticfiles | Version: | 1.7-rc-3 |
| Severity: | Release blocker | Keywords: | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | yes |
| Easy pickings: | no | UI/UX: | no |
Description
StaticLiveServerCase is a children of django.test.LiveServerTestCase and it seems like a mistake that it's named StaticLiveServerCase instead of StaticLiveServerTestCase.
I'm setting it as release blocker just because if it's not fixed at release time, then we will have to keep compatibility with that strange name.
The attached patch is for master but it should also be applied to stable/1.7.x obviously.
Attachments (1)
Change History (4)
Changed 9 years ago by
| Attachment: | 0001-Rename-StaticLiveServerCase-into-more-natural-Static.patch added |
|---|
comment:1 Changed 9 years ago by
| Owner: | changed from nobody to Claude Paroz |
|---|---|
| Patch needs improvement: | set |
| Status: | new → assigned |
| Triage Stage: | Unreviewed → Accepted |
comment:2 Changed 9 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Note: See
TracTickets for help on using
tickets.
Was introduced in [e909ceae9b3e72b72e0a2baaa92bba9714f18cd2] / #20739. Makes sense, but the patch misses some occurrences.