Opened 10 months ago

Closed 10 months ago

Last modified 10 months ago

#23374 closed Cleanup/optimization (fixed)

django.contrib.staticfiles.testing.StaticLiveServerCase should be named StaticLiveServerTestCase

Reported by: rhertzog Owned by: claudep
Component: contrib.staticfiles Version: 1.7-rc-3
Severity: Release blocker Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

StaticLiveServerCase is a children of django.test.LiveServerTestCase and it seems like a mistake that it's named StaticLiveServerCase instead of StaticLiveServerTestCase.

I'm setting it as release blocker just because if it's not fixed at release time, then we will have to keep compatibility with that strange name.

The attached patch is for master but it should also be applied to stable/1.7.x obviously.

Attachments (1)

0001-Rename-StaticLiveServerCase-into-more-natural-Static.patch (1.9 KB) - added by rhertzog 10 months ago.

Download all attachments as: .zip

Change History (4)

comment:1 Changed 10 months ago by claudep

  • Needs documentation unset
  • Needs tests unset
  • Owner changed from nobody to claudep
  • Patch needs improvement set
  • Status changed from new to assigned
  • Triage Stage changed from Unreviewed to Accepted

Was introduced in [e909ceae9b3e72b72e0a2baaa92bba9714f18cd2] / #20739. Makes sense, but the patch misses some occurrences.

comment:2 Changed 10 months ago by Claude Paroz <claude@…>

  • Resolution set to fixed
  • Status changed from assigned to closed

In 3a44e20005e654affea89af49d82532d4d55e4a7:

Fixed #23374 -- Renamed StaticLiveServerCase to StaticLiveServerTestCase

Refs #20739. Thanks Raphaël Hertzog for the report and the initial
patch.

comment:3 Changed 10 months ago by Claude Paroz <claude@…>

In 9ac713645bb870c45d7aaf16b003e392f62d4ea3:

[1.7.x] Fixed #23374 -- Renamed StaticLiveServerCase to StaticLiveServerTestCase

Refs #20739. Thanks Raphaël Hertzog for the report and the initial
patch.
Backport of 3a44e2000 from master.

Note: See TracTickets for help on using tickets.
Back to Top