[patch] is_loggedin method for User and AnonymousUser models.

[Chris Beaven]

This is_loggedin method replaces the is_anonymous method.

Discussion from the django-developers group follows (​see thread).

Templates treat non-existing variables as False; therefore; a
request.user somehow failing to get assigned would result in the
template treating the user as they are authenticated (is_anonymous
evaluates False). An is_loggedin would be a more secure option because
if request.user failed to get assigned, the template would treat the
user as anonymous.

I would much rather mistakenly treat an authenticated user as anonymous
than mistakenly treat an anonymous user as authenticated.

[Chris Beaven]

is_loggedin implementation - also replaces all is_anonymous references with negative is_loggedin

[Malcolm Tredinnick]

I don't like the name. Either is_authenticated or is_logged_in seem better.

Although using "login" as a single word verb is becoming common and even acceptable in some style guides (when I rule the universe, there are going to be changes made, let me tell you), I don't think we should encourage "loggedin" to be its past tense. :-) That can be fixed when we apply this.

There are some docs changes required as well that are not in this patch.

[Gary Wilson <gary.wilson@…>]

is_logged_in implementation with doc changes and deprecation warnings in is_anonymous

[Gary Wilson <gary.wilson@…>]

discussion is here:
​http://groups.google.com/group/django-developers/browse_thread/thread/2cc178fe7c8c9046/02561f32714d4b08

[Gary Wilson <gary.wilson@…>]

is_authenticated implementation with doc changes and NO deprecation warnings in is_anonymous

[Gary Wilson <gary.wilson@…>]

is_authenticated implementation with doc changes and NO deprecation warnings in is_anonymous, slight change in documentation wording

[Malcolm Tredinnick]

(In [3360]) Fixed #2332 -- Introduced is_authenticated() method on User and AnonymousUser classes. Recommended its use over is_anonymous in the docs. Changed internal Django use to match this recommendation. Thanks to SmileyChris and Gary Wilson for the patch.