Management command dbshell does not use DATABASE[...]['OPTIONS'] to set env PGOPTIONS

[benjaoming]

I am trying to make use of a different "search_path" by use of settings.DATABASE[...]['OPTIONS'] = '-c search_path=my_other_schema,public' -- however, since they are not passed, python manage.py dbshell --database=MY_OTHER_DATABASE_CONNECTION will yield an unexpected result.

The problem is that the shell env variable PGOPTIONS="-c search_path=MY_SEARCH_PATH_CONF" is not set.

I am using it for the purpose of having multiple south_migrationhistory tables, one for every database connection. They should have been populated by:

python manage.py sqlall south | python manage.py dbshell --database=DBNAME

Current work-around:

python manage.py sqlall south | PGOPTIONS="-c search_path=NAME_OF_MY_SCHEMA" python manage.py dbshell --database=DBNAME

I am not sure how 1.7 will handle migration histories when populating different database connections and auto-selecting them using routers. But at least having the above to work would be nice, because it makes it easy to manually pipe around the SQL statements to different DB connections.

Also in more severe cases, not having the connection options passed to dbshell might yield other unexpected results!?

This might be of interest to other db backends, but please limit the issue here to only postgres, as it's perfectly simple to copy in the contents of OPTIONS to the env variable PGOPTIONS.

[Tim Graham]

It looks like a reasonable request, and we recently enhanced the options that dbshell accepts when using MySQL (#22646).

[Flavio Curella]

PR up at ​https://github.com/django/django/pull/3168

[Tim Graham]

I left comments for improvement on the PR. Please uncheck "Patch needs improvement" when you update it, thanks.

[Dulmandakh]

PR ​https://github.com/django/django/pull/12715

[Dulmandakh]

The implementation differs from initial implementation because OPTIONS may be used to set many connection configurations of psycopg2 other than options or PGOPTIONS.

[Mariusz Felisiak]

Replying to Dulmandakh:

.... may be used to set many connection configurations of psycopg2 other than options or PGOPTIONS.

I'm not sure what does it mean? You want to pass options to the PGOPTIONS so how it can support sth else? The list of all available options can be found in ​the PostgreSQL docs. Also I'm not sure (​as pointed by Tim) if passing all possible options is safe.

[Dulmandakh]

Replying to felixxm:

Replying to Dulmandakh:

.... may be used to set many connection configurations of psycopg2 other than options or PGOPTIONS.

I'm not sure what does it mean? You want to pass options to the PGOPTIONS so how it can support sth else? The list of all available options can be found in ​the PostgreSQL docs. Also I'm not sure (​as pointed by Tim) if passing all possible options is safe.

IIRC, OPTIONS passed to ​psycopg2.connect method directly as a part of kwargs, so it might be best to not interfere with it. Also we cannot determine which options are safe or not, so it might be best to leave it a web developer to decide.

[Jacob Walls]

Improvement flag was set on previous patch, so unsetting for new patch and assigning to PR author.