Opened 8 months ago

Closed 8 months ago

#23303 closed Cleanup/optimization (fixed)

sqlmigrate doesn't output BEGIN and COMMIT statements

Reported by: bmispelon Owned by: nobody
Component: Core (Management commands) Version: 1.7-rc-2
Severity: Release blocker Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

All other sql* commands wrap their output in BEGIN; ... COMMIT; statements.

PR here: https://github.com/django/django/pull/3076

Change History (9)

comment:1 Changed 8 months ago by timgraham

  • Has patch set
  • Patch needs improvement set
  • Severity changed from Normal to Release blocker
  • Triage Stage changed from Unreviewed to Accepted
  • Version changed from 1.7-beta-2 to 1.7-rc-2

comment:2 Changed 8 months ago by timgraham

  • Patch needs improvement unset
  • Triage Stage changed from Accepted to Ready for checkin

comment:3 Changed 8 months ago by Baptiste Mispelon <bmispelon@…>

  • Resolution set to fixed
  • Status changed from new to closed

In 5853c87a458f62ebd62d7809168355610de2570c:

Fixed #23303 -- Added BEGIN and COMMIT statements to the output of sqlmigrate.

comment:4 Changed 8 months ago by Baptiste Mispelon <bmispelon@…>

In 3a80189479a29220bac6d205a1b97184bd76a876:

[1.7.x] Fixed #23303 -- Added BEGIN and COMMIT statements to the output of sqlmigrate.

Backport of 5853c87a458f62ebd62d7809168355610de2570c from master.

Conflicts:

django/core/management/commands/sqlmigrate.py
tests/user_commands/tests.py

comment:5 Changed 8 months ago by timgraham

  • Resolution fixed deleted
  • Status changed from closed to new

One minor issue with the tests: Oracle doesn't include BEGIN; in its transactions.

comment:6 Changed 8 months ago by Baptiste Mispelon <bmispelon@…>

In 54164b814cab71a8a0503743befbdcc99ae6c7a0:

Fixed broken tests on Oracle after 5853c87a458f62ebd62d7809168355610de2570c.

Oracle doesn't have a BEGIN statement so the test would
fail.

Refs #23303

comment:7 Changed 8 months ago by Baptiste Mispelon <bmispelon@…>

In 24d9aee1880ced5892af42f35539a5d705adf512:

[1.7.x] Fixed broken tests on Oracle after 5853c87a458f62ebd62d7809168355610de2570c.

Oracle doesn't have a BEGIN statement so the test would
fail.

Refs #23303

Backport of 54164b814cab71a8a0503743befbdcc99ae6c7a0 from master.

comment:8 Changed 8 months ago by andrewgodwin

Why is this reopened? It looks like the other DBs will still get BEGIN/END

comment:9 Changed 8 months ago by bmispelon

  • Resolution set to fixed
  • Status changed from new to closed

Sorry, I forgot to close it again after 54164b814cab71a8a0503743befbdcc99ae6c7a0.

Note: See TracTickets for help on using tickets.
Back to Top