Opened 10 years ago

Closed 10 years ago

#2326 closed defect (fixed)

[patch] contrib.auth.models catches exceptions wrongly

Reported by: mir@… Owned by: Adrian Holovaty
Component: Contrib apps Version: master
Severity: normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

It's quite trivial:

line 242:

            except ImportError, ImproperlyConfigured:

This will not catch ImproperlyConfigured, you need () around it. See patch.

Attachments (1)

auth-models-exception.diff (552 bytes) - added by mir@… 10 years ago.
promised patch

Download all attachments as: .zip

Change History (2)

Changed 10 years ago by mir@…

Attachment: auth-models-exception.diff added

promised patch

comment:1 Changed 10 years ago by Adrian Holovaty

Resolution: fixed
Status: newclosed

(In [3328]) Fixed #2326 -- Fixed exception catching in django.contrib.auth.models. Thanks, mir@…

Note: See TracTickets for help on using tickets.
Back to Top