Opened 10 years ago

Closed 10 years ago

#23136 closed Cleanup/optimization (fixed)

sqlclear does not notify operator that there is nothing to clear

Reported by: jackiekazil Owned by: Gabriel Muñumel
Component: Core (Management commands) Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: yes UI/UX: no


I tried passing sqlclear to dbshell and came up with this error, which was non-descript.

$ sqlclear foia_core | dbshell
ERROR:  syntax error at or near "/"
LINE 1: /Users/jacquelinekazil/Projects/code/foia/foia-core/foia_cor...

Then I tried running each command separately. When I ran sqlclear, nothing appeared to happened.

$ sqlclear foia_core

This is confusing to user if they are expecting something to happen. There should be output to tell the user what happened.
Example: Foo app has no tables in the database.

Change History (10)

comment:1 by Russell Keith-Magee, 10 years ago

Triage Stage: UnreviewedAccepted

Sounds reasonable, and shouldn't be too hard to implement either. Might be worth checking if other sql* commands are also affected as well.

comment:2 by Tim Graham, 10 years ago

I believe most of the sql* commands besides sqlmigrate are headed down the deprecation path, so this might not be worth it.

comment:3 by Gabriel Muñumel, 10 years ago

I´d like to implement this if there is not objection.

comment:4 by Gabriel Muñumel, 10 years ago

Owner: changed from nobody to Gabriel Muñumel
Status: newassigned

comment:6 by Tim Graham, 10 years ago

Couple of issues:

  • New features are going to master only (not 1.6).
  • I only see a test in your commit, not the functional changes (and it isn't an actual pull request).

comment:8 by Tim Graham, 10 years ago

Has patch: set
Patch needs improvement: set
Version: 1.6master

comment:9 by Gabriel Muñumel, 10 years ago

I made the changes Timo

comment:10 by Tim Graham, 10 years ago

Resolution: fixed
Status: assignedclosed

In 3e241313a4cea5dbf53068181408a7c34f00c9ca:

Fixed #23136 -- Added a message when sqlclear does nothing

Note: See TracTickets for help on using tickets.
Back to Top