Opened 11 years ago

Closed 11 years ago

#23113 closed Bug (fixed)

ChoiceInput.render() should take specified attrs into account.

Reported by: Simon Charette Owned by: nobody
Component: Forms Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

When attempting to render a ChoiceInput instance with additional attrs (using a template filter for example) they are simply ignored which is a digression from the usual widget API that merges them with its instance ones.

@claudep, the issue existed in 1.6 so this is not a regression.

Change History (3)

comment:1 by Simon Charette, 11 years ago

Has patch: set

​PR with test.

comment:2 by Tim Graham, 11 years ago

Triage Stage: Unreviewed → Ready for checkin

comment:3 by Simon Charette <charette.s@…>, 11 years ago

Resolution: → fixed
Status: new → closed

In 80708ac77204c491f86c6a8215aaba8cf0989154:

Fixed #23113 -- ChoiceInput.render should take specified attrs into account.

Thanks to Tim Graham for the review.

Note: See TracTickets for help on using tickets.
Back to Top