Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#23092 closed Bug (fixed)

Squasing migrations doesn't handles or warns about external dependencies

Reported by: Piotr Maliński Owned by: nobody
Component: Migrations Version: 1.7-rc-2
Severity: Release blocker Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Squashed migration won't keep external dependencies nor the command will warn about manually re-adding them.

Change History (5)

comment:1 by Tim Graham, 11 years ago

Could you describe this more or add an example?

comment:2 by Piotr Maliński, 11 years ago

When I have some dependencies in existing migrations like:

dependencies = [
        migrations.swappable_dependency(settings.AUTH_USER_MODEL),
        ('some_app', 'some_migration'),
    ]

then in squashed migration dependencies list will be empty.

comment:3 by Tim Graham, 11 years ago

Severity: Normal → Release blocker
Triage Stage: Unreviewed → Accepted
Type: Uncategorized → Bug
Version: 1.7-rc-1 → 1.7-rc-2

Thanks, I could reproduce this.

comment:4 by Andrew Godwin <andrew@…>, 11 years ago

Resolution: → fixed
Status: new → closed

In 096a5de5d2bf564f859eca115874f5643ef31658:

Fixed #23092: Squashing handles external dependencies

comment:5 by Andrew Godwin <andrew@…>, 11 years ago

In 8e7fdfdb6fb0e910d5b507ba2da56a297bfba25c:

[1.7.x] Fixed #23092: Squashing handles external dependencies

Note: See TracTickets for help on using tickets.
Back to Top