Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#23078 closed Bug (fixed)

update_contenttypes interactive kwarg will always be False

Reported by: raymond@… Owned by: nobody
Component: contrib.contenttypes Version: 1.7-rc-1
Severity: Release blocker Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

I've been noticing that stale content types are no longer removed during syncdb / migrate. Looking at the master and the c1 branch I've found the problem.

django/contrib/contenttypes/management.py line 63: kwargs.get('interactive', False)

Will always be False due to the function signature which defines kwarg interactive=True.

Change History (10)

comment:1 Changed 8 years ago by Tim Graham

Component: Uncategorizedcontrib.contenttypes
Easy pickings: unset
Severity: NormalRelease blocker
Triage Stage: UnreviewedAccepted

The interactive kwarg was introduced in 00110904ac67050c639f93cfd7b5e19218bcef5b.

comment:2 Changed 8 years ago by merb

I added a pr for this: https://github.com/django/django/pull/2942

Edit: God Trac is so fucking dumb..

Last edited 8 years ago by merb (previous) (diff)

comment:3 Changed 8 years ago by merb

Needs tests: set
Resolution: fixed
Status: newclosed

comment:4 Changed 8 years ago by merb

Resolution: fixed
Status: closednew

comment:5 Changed 8 years ago by Nick Sandford

Has patch: set
Needs tests: unset

I added some tests, PR here: https://github.com/django/django/pull/2944

comment:6 Changed 8 years ago by Nick Sandford

Triage Stage: AcceptedReady for checkin

comment:7 Changed 8 years ago by Tim Graham <timograham@…>

Resolution: fixed
Status: newclosed

In fa3cf006b2912708e8c0b294cea91933cf35781f:

Fixed #23078 -- Regression in update_contenttypes() interactivity.

Thanks raymond at adaptiv.nl for the report.

comment:8 Changed 8 years ago by Tim Graham <timograham@…>

In 9638daec5cb584dc3b62b7373e0f7cd2fc808b7e:

[1.7.x] Fixed #23078 -- Regression in update_contenttypes() interactivity.

Thanks raymond at adaptiv.nl for the report.

Backport of fa3cf006b2 from master

comment:9 Changed 8 years ago by Tim Graham <timograham@…>

In 936fba5878075576570ab7d2c84bfba80d183c18:

Improved patching of sys.stdout in refs #23078.

comment:10 Changed 8 years ago by Tim Graham <timograham@…>

In 7cbb4f79d1e3f1690fb31b118f47590d9470b59b:

[1.7.x] Improved patching of sys.stdout in refs #23078.

Backport of 936fba5878 from master

Note: See TracTickets for help on using tickets.
Back to Top