Opened 11 years ago

Last modified 6 days ago

#22997 assigned Bug

Migration fails when removing explicit primary key

Reported by: a.lloyd.flanagan@… Owned by: bcail
Component: Migrations Version: 1.7
Severity: Normal Keywords: migrate primary_key
Cc: bcail Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

The automatic migration created by migrate fails when

  • a table was created with a field where "primary_key=True" is specified.
  • data is added to the table
  • The model is modified so that no field is primary key, and Django auto-creates "id" field.

To reproduce the problem:

  1. create new model, set some field as primary key
  2. set up migrations with initial migration
  3. modify model so field is not primary key
  4. generate migration

Problems:

  • will ask for default value for auto-generated ID field
  • will try to create id field as primary key, before modifying existing key

Manual Fix:

  • remove default from models.AutoField() call
  • reverse order of operations so AlterField() comes before AddField()

I'm attaching a session log with a complete transcript.

Attachments (1)

django_session_log.txt​ (7.5 KB ) - added by a.lloyd.flanagan@… 11 years ago.
Terminal session log demonstrating issue in 22997.

Download all attachments as: .zip

Change History (18)

by a.lloyd.flanagan@…, 11 years ago

Attachment: django_session_log.txt​ added

Terminal session log demonstrating issue in 22997.

comment:1 by Tim Graham, 11 years ago

Component: Database layer (models, ORM) → Migrations
Triage Stage: Unreviewed → Accepted
Type: Uncategorized → Bug

I guess it's probably too much of an edge case to be a blocker for 1.7, but would be nice if it "just worked".

comment:2 by Tim Graham, 10 years ago

Version: 1.7-rc-1 → 1.7

comment:3 by Tim Graham, 10 years ago

#24030 seems related.

comment:4 by bcail, 12 months ago

Cc: bcail added
Has patch: set
Owner: changed from nobody to bcail
Status: new → assigned

I opened ​a PR for one of the problems - where a default is added to an AutoField.

comment:5 by bcail, 12 months ago

I updated the PR to handle the other issue as well - to generate altered fields before added fields.

comment:6 by Bhuvnesh, 10 months ago

Patch needs improvement: set

comment:7 by bcail, 10 months ago

Patch needs improvement: unset

comment:8 by Sarah Boyce, 10 months ago

Summary: Migration fails when removing explicit primary key (Postgres) → Migration fails when removing explicit primary key

(I can replicate also on SQLite so removing Postgres reference as it does not only relate to Postgres)

comment:9 by Sarah Boyce, 10 months ago

Summary: Migration fails when removing explicit primary key → Migration fails when removing explicit primary key (Postgres)

(Ah perhaps the fix as described is only related to Postgres? Can confirm the same migrations and prompting happen on other databases).

comment:10 by Sarah Boyce, 10 months ago

Patch needs improvement: set
Summary: Migration fails when removing explicit primary key (Postgres) → Migration fails when removing explicit primary key

#35416 is a duplicate.
Marking "Patch needs improvement" as the case, as described in #35416, needs to be handled.

comment:11 by Sarah Boyce, 5 months ago

#35761 is a duplicate

comment:12 by bcail, 4 months ago

Patch needs improvement: unset

comment:13 by bcail, 4 months ago

​Another PR that just addresses part of this ticket.

comment:14 by Sarah Boyce, 7 days ago

Triage Stage: Accepted → Ready for checkin

comment:15 by Sarah Boyce <42296566+sarahboyce@…>, 6 days ago

In db7b1ae9:

Refs #22997 -- Prevented requesting a default value for auto fields.

comment:16 by Sarah Boyce <42296566+sarahboyce@…>, 6 days ago

In d57bf461:

[5.2.x] Refs #22997 -- Prevented requesting a default value for auto fields.

Backport of db7b1ae9f6d9e26facbb3da4cf5f5a513704bfe5 from main.

comment:17 by Sarah Boyce, 6 days ago

Patch needs improvement: set
Triage Stage: Ready for checkin → Accepted
Note: See TracTickets for help on using tickets.
Back to Top