Opened 9 months ago

Last modified 6 weeks ago

#22993 new Cleanup/optimization

Drop skipIfCustomUser decorator

Reported by: timo Owned by: nobody
Component: contrib.auth Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no


With the test discovery changes in 1.6, the tests for django.contrib apps are no longer run as part of user's project. For this reason I believe we no longer need to decorate tests in contrib.auth with @skipIfCustomUser.

Change History (3)

comment:1 Changed 9 months ago by timo

  • Triage Stage changed from Unreviewed to Someday/Maybe

django-developers thread. Consensus seems to be that we shouldn't drop it now because of projects that may still be using the old test runner.

comment:2 Changed 6 weeks ago by MarkusH

  • Triage Stage changed from Someday/Maybe to Accepted

Can we still deprecate it in 1.8? That way developers can use it through the LTS version and only need to upgrade to the next LTS after 1.8 and we can get rid of it in 2.0. If deprecation time for 1.8 is already over, let's do it for 1.9. Either way should give users plenty of time to update their test suite.

comment:3 Changed 6 weeks ago by timgraham

I'm not quite understanding your argument for why it would be advantageous to deprecate for 1.8. I think 1.9 is fine.

Note: See TracTickets for help on using tickets.
Back to Top