Opened 14 months ago

Closed 13 months ago

Last modified 13 months ago

#22979 closed Cleanup/optimization (fixed)

Move bug* tests

Reported by: timo Owned by: tushar
Component: Uncategorized Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

tests/bug(639|8245) should be combined with another test app.

Change History (6)

comment:1 Changed 14 months ago by tushar

  • Owner changed from nobody to tushar
  • Status changed from new to assigned

comment:2 Changed 14 months ago by tushar

I propose that bug #8245 should be moved to tests.admin_checks and renamed from test_bug_8245 to test_double_call_autodiscover. Also that bug #639 be moved to tests.forms_tests.tests.test_extra and renamed from test_bug_639 to test_file_upload_form_save. I will write the patch, can someone confirm that these are the appropriate changes to be made?

comment:3 Changed 13 months ago by timo

admin_checks is for tests related to the system checks framework so I don't think it's a good place for that bug. I don't see any other tests for admin.autodiscover(), but how about renaming the bug8245 directory to admin_autodiscover.

forms_tests.tests.test_extra is for testing django.forms.extras which isn't applicable for bug639. Try to find a place where FileField is tested with ModelForm.

comment:4 Changed 13 months ago by tushar

Thanks for the help. I've submitted a pull request: https://github.com/django/django/pull/2961.

comment:5 Changed 13 months ago by Tim Graham <timograham@…>

  • Resolution set to fixed
  • Status changed from assigned to closed

In 11181a64f947236402903deb6fa8c4df7b8bff75:

Fixed #22979 -- Moved bug* tests

comment:6 Changed 13 months ago by Tim Graham <timograham@…>

In df0d5ea7bc9821923c70e7bf06d3646598cf019d:

[1.7.x] Fixed #22979 -- Moved bug* tests

Backport of 11181a64f from master.

Note: See TracTickets for help on using tickets.
Back to Top