#22979 closed Cleanup/optimization (fixed)
Move bug* tests
| Reported by: | Tim Graham | Owned by: | Tushar Bhatia |
|---|---|---|---|
| Component: | Uncategorized | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | no | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | yes | UI/UX: | no |
Description
tests/bug(639|8245) should be combined with another test app.
Change History (6)
comment:1 by , 10 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
comment:2 by , 10 years ago
comment:3 by , 10 years ago
admin_checks is for tests related to the system checks framework so I don't think it's a good place for that bug. I don't see any other tests for admin.autodiscover(), but how about renaming the bug8245 directory to admin_autodiscover.
forms_tests.tests.test_extra is for testing django.forms.extras which isn't applicable for bug639. Try to find a place where FileField is tested with ModelForm.
comment:4 by , 10 years ago
Thanks for the help. I've submitted a pull request: https://github.com/django/django/pull/2961.
comment:5 by , 10 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Note:
See TracTickets
for help on using tickets.
I propose that bug #8245 should be moved to tests.admin_checks and renamed from test_bug_8245 to test_double_call_autodiscover. Also that bug #639 be moved to tests.forms_tests.tests.test_extra and renamed from test_bug_639 to test_file_upload_form_save. I will write the patch, can someone confirm that these are the appropriate changes to be made?