Opened 18 years ago

Closed 14 years ago

Last modified 14 years ago

#2283 closed defect (fixed)

[patch] comment form templates don't validate as XHTML strict

Reported by: fonso Owned by: Adrian Holovaty
Component: contrib.comments Version:
Severity: minor Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The comment form templates in contrib/comments/templates/comments don't validate as XHTML 1.0 Strict (don't know if they'd validate in Transitional) due to the lack of a block-level container for the hidden input fields.

Attachments (2)

valid_comment_form_templates.diff​ (1.8 KB ) - added by fonso 18 years ago.
2283.diff​ (4.7 KB ) - added by Thejaswi Puthraya 16 years ago.
git-patch against the latest checkout

Download all attachments as: .zip

Change History (15)

by fonso, 18 years ago

Attachment: valid_comment_form_templates.diff​ added

comment:1 by Adrian Holovaty, 18 years ago

Resolution: → fixed
Status: new → closed

(In [3283]) Fixed #2283 -- Fixed XHTML-strict validation error in comment templates

comment:2 by hjoreteg, 16 years ago

Resolution: fixed
Status: closed → reopened

This seems to be a problem again. The hidden fields produced by the template "form.html" in django.contrib.comments.templates do not validate with XHTML Strict because they are inline elements without a block-level container.

I'm using version 1.1.0 alpha Django

comment:3 by call_of_duty_6, 16 years ago

The hidden fields produced by the template *​files "form.html" in django.contrib.comments.templates do not validate with XHTML Strict because they are inline elements without a block-level container.

comment:4 by Jacob, 16 years ago

Triage Stage: Unreviewed → Accepted

comment:5 by Thejaswi Puthraya, 16 years ago

Component: Contrib apps → django.contrib.comments

Wow, can't believe this bug existed in both versions and took so long to fix.

by Thejaswi Puthraya, 16 years ago

Attachment: 2283.diff​ added

git-patch against the latest checkout

comment:6 by Thejaswi Puthraya, 16 years ago

The admin and forms use XHTML and some tags in the comments (like IMG and Meta) were usign XHTML,
so I thought why not convert everything to XHTML for uniformity.

comment:7 by Adam Nelson, 15 years ago

Triage Stage: Accepted → Design decision needed

Seems like this should go back to a design decision:

​http://groups.google.com/group/django-developers/browse_thread/thread/201d6758f4d88dcd/a65fbbc8effcd914?#a65fbbc8effcd914

comment:8 by Malcolm Tredinnick, 14 years ago

Triage Stage: Design decision needed → Accepted

No idea why this is DDN. Forms should be XHTML in django at the moment.

comment:9 by Luke Plant, 14 years ago

We are currently standardised on XHTML for all templates/forms, but not necessarily XHTML Strict - some existing templates use Transitional, and this is less likely to cause problems with content. So I will modify this patch to use XHTML Transitional doctypes. Also, I'll use div instead of p for hidden element, since a plain 'div' is less likely than 'p' to have a margin set that might cause unsightly gaps.

I'll commit shortly.

comment:10 by Luke Plant, 14 years ago

Resolution: → fixed
Status: reopened → closed

(In [13855]) Fixed #2283 (again) - comment form templates don't validate as XHTML

Thanks to hjoreteg/thejaswi_puthraya for the report and patch.

comment:11 by Luke Plant, 14 years ago

(In [13856]) [1.2.X] Fixed #2283 (again) - comment form templates don't validate as XHTML

Thanks to hjoreteg/thejaswi_puthraya for the report and patch.

Backport of [13855] from trunk

comment:13 by Luke Plant, 14 years ago

Thanks for the catch jezdez, will fix shortly.

Note: See TracTickets for help on using tickets.
Back to Top