#22826 closed Cleanup/optimization (fixed)
Simplify Query.setup_joins
| Reported by: | jorgecarleitao | Owned by: | jorgecarleitao |
|---|---|---|---|
| Component: | Database layer (models, ORM) | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | jorgecarleitao | Triage Stage: | Unreviewed |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
Currently, not all arguments returned by Query.setup_joins are being used all the times.
On the other hand, some arguments are systematically being used in common things (e.g. join_list[-1])
I propose to have a minor cleanup on these as part of an effort to simplify the entanglement between
Query, SQLCompiler, and SQLEvalutor.
This is a minor simplification and doesn't affect any public API.
Change History (4)
comment:1 by , 10 years ago
comment:3 by , 10 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
This is easier to explain with code... I will submit a PR to explain what I mean.