Opened 13 months ago

Closed 13 months ago

Last modified 13 months ago

#22826 closed Cleanup/optimization (fixed)

Simplify Query.setup_joins

Reported by: jorgecarleitao Owned by: jorgecarleitao
Component: Database layer (models, ORM) Version: master
Severity: Normal Keywords:
Cc: jorgecarleitao Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Currently, not all arguments returned by Query.setup_joins are being used all the times.

On the other hand, some arguments are systematically being used in common things (e.g. join_list[-1])

I propose to have a minor cleanup on these as part of an effort to simplify the entanglement between
Query, SQLCompiler, and SQLEvalutor.

This is a minor simplification and doesn't affect any public API.

Change History (4)

comment:1 Changed 13 months ago by jorgecarleitao

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

This is easier to explain with code... I will submit a PR to explain what I mean.

comment:2 Changed 13 months ago by jorgecarleitao

  • Has patch set
Last edited 13 months ago by jorgecarleitao (previous) (diff)

comment:3 Changed 13 months ago by Jorge C. Leitão <jorgecarleitao@…>

  • Resolution set to fixed
  • Status changed from new to closed

In e66896226a41eb9e56b08d7adf29b44c0cd87dad:

Fixed #22826 -- Improved internal usage of Query.setup_joins.

comment:4 Changed 13 months ago by Marc Tamlyn <marc.tamlyn@…>

In dd57b89fcb8f009fc73f16efea9539e5888eb59d:

Merge pull request #2806 from jorgecarleitao/issue22826

Fixed #22826 -- Improved internal usage of Query.setup_joins.

Note: See TracTickets for help on using tickets.
Back to Top