GET and POST on HttpRequest should be QueryDicts

[duncan@…]

On a new HttpRequest object, GET and POST are are empty dictionaries when they really ought to be QueryDicts. This is not something you would usually notice causing trouble in production as you get a WSGIRequest instead of an HttpRequest, but in testing using the test client, calling .getlist on GET or POST for a request with no get/post data results in an AttributeError.

I've made a pull request to change this: ​https://github.com/django/django/pull/2778

[Baptiste Mispelon]

Hi,

This seems like a reasonable feature to add.

I've left a comment on the pull request and on top of that, you should also add a mention in the release notes for 1.8.

Thanks.

[duncan]

I've updated the pull request in line with bmispelon's suggestions, let me know if there is anything else you need.

Cheers,

Duncan

[Tim Graham <timograham@…>]

In fd4ccd045cf8edf0bf10ee0c576c7b7c5819170c:

Fixed #22799 -- Made GET and POST on HttpRequest QueryDicts, and FILES a MultiValueDict.

Previously, GET, POST, and FILES on an HttpRequest were created in
the init method as dictionaries. This was not something you would
usually notice causing trouble in production as you'd only see a
WSGIRequest, but in testing using the test client, calling .getlist
on GET, POST, or FILES for a request with no get/post data resulted in
an AttributeError.

Changed GET and POST on an HttpRequest object to be mutable
QueryDicts (mutable because the Django tests, and probably many
third party tests, were expecting it).