#22782 closed New feature (fixed)
Add i18n to sitemap
| Reported by: | luanpab | Owned by: | luanpab |
|---|---|---|---|
| Component: | contrib.sitemaps | Version: | dev |
| Severity: | Normal | Keywords: | sitemap, i18n |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
Add I18n support to the Sitemap class, making it possible to have your multiple language URLs in the sitemap.
Attachments (2)
Change History (12)
comment:1 by , 10 years ago
comment:2 by , 10 years ago
| Needs documentation: | set |
|---|---|
| Needs tests: | set |
follow-up: 4 comment:3 by , 10 years ago
| Needs documentation: | unset |
|---|---|
| Needs tests: | unset |
comment:4 by , 10 years ago
Replying to luanpab:
Sorry about that, I'm new at this ticket tracker. I haven't noticed you've changed the options. Already changed it back.
Thank you.
comment:5 by , 10 years ago
I agree with the API proposed in the pull request. It just needs some polish.
comment:6 by , 10 years ago
| Patch needs improvement: | set |
|---|---|
| Triage Stage: | Unreviewed → Accepted |
I left comments for improvement on PR. Please uncheck "Patch needs improvement" when you update it, thanks.
comment:7 by , 10 years ago
| Patch needs improvement: | unset |
|---|
by , 10 years ago
| Attachment: | i18nsitemap.2.diff added |
|---|
by , 10 years ago
| Attachment: | i18nsitemap.diff added |
|---|
comment:8 by , 10 years ago
I've updated the code and the diff file. Someone please delete the "i18nsitemap.2.diff" attachment. I forgot to check the replace file check box.
Thank you.
comment:9 by , 10 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
PR is here. (No need to attach a patch, just link the PR).