Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#22782 closed New feature (fixed)

Add i18n to sitemap

Reported by: luanpab Owned by: luanpab
Component: contrib.sitemaps Version: dev
Severity: Normal Keywords: sitemap, i18n
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Add I18n support to the Sitemap class, making it possible to have your multiple language URLs in the sitemap.

Attachments (2)

i18nsitemap.2.diff (7.6 KB ) - added by luanpab 10 years ago.
i18nsitemap.diff (7.6 KB ) - added by luanpab 10 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 by Tim Graham, 10 years ago

PR is here. (No need to attach a patch, just link the PR).

comment:2 by luanpab, 10 years ago

Needs documentation: set
Needs tests: set

comment:3 by luanpab, 10 years ago

Needs documentation: unset
Needs tests: unset

in reply to:  3 comment:4 by luanpab, 10 years ago

Replying to luanpab:
Sorry about that, I'm new at this ticket tracker. I haven't noticed you've changed the options. Already changed it back.

Thank you.

comment:5 by Aymeric Augustin, 10 years ago

I agree with the API proposed in the pull request. It just needs some polish.

comment:6 by Tim Graham, 10 years ago

Patch needs improvement: set
Triage Stage: UnreviewedAccepted

I left comments for improvement on PR. Please uncheck "Patch needs improvement" when you update it, thanks.

comment:7 by luanpab, 10 years ago

Patch needs improvement: unset

by luanpab, 10 years ago

Attachment: i18nsitemap.2.diff added

by luanpab, 10 years ago

Attachment: i18nsitemap.diff added

comment:8 by luanpab, 10 years ago

I've updated the code and the diff file. Someone please delete the "i18nsitemap.2.diff" attachment. I forgot to check the replace file check box.

Thank you.

comment:9 by Tim Graham <timograham@…>, 10 years ago

Resolution: fixed
Status: newclosed

In 407d070329b4df81dab488db35bb068976e3be43:

Fixed #22782 -- Added i18n attr to Sitemap class

It makes possible to have your sitemap in multiple languages when
using i18n in URLs.

comment:10 by Tim Graham <timograham@…>, 10 years ago

Note: See TracTickets for help on using tickets.
Back to Top