Opened 14 months ago

Closed 14 months ago

Last modified 14 months ago

#22782 closed New feature (fixed)

Add i18n to sitemap

Reported by: luanpab Owned by: luanpab
Component: contrib.sitemaps Version: master
Severity: Normal Keywords: sitemap, i18n
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Add I18n support to the Sitemap class, making it possible to have your multiple language URLs in the sitemap.

Attachments (2)

i18nsitemap.2.diff (7.6 KB) - added by luanpab 14 months ago.
i18nsitemap.diff (7.6 KB) - added by luanpab 14 months ago.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 14 months ago by timo

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

PR is here. (No need to attach a patch, just link the PR).

comment:2 Changed 14 months ago by luanpab

  • Needs documentation set
  • Needs tests set

comment:3 follow-up: Changed 14 months ago by luanpab

  • Needs documentation unset
  • Needs tests unset

comment:4 in reply to: ↑ 3 Changed 14 months ago by luanpab

Replying to luanpab:
Sorry about that, I'm new at this ticket tracker. I haven't noticed you've changed the options. Already changed it back.

Thank you.

comment:5 Changed 14 months ago by aaugustin

I agree with the API proposed in the pull request. It just needs some polish.

comment:6 Changed 14 months ago by timo

  • Patch needs improvement set
  • Triage Stage changed from Unreviewed to Accepted

I left comments for improvement on PR. Please uncheck "Patch needs improvement" when you update it, thanks.

comment:7 Changed 14 months ago by luanpab

  • Patch needs improvement unset

Changed 14 months ago by luanpab

Changed 14 months ago by luanpab

comment:8 Changed 14 months ago by luanpab

I've updated the code and the diff file. Someone please delete the "i18nsitemap.2.diff" attachment. I forgot to check the replace file check box.

Thank you.

comment:9 Changed 14 months ago by Tim Graham <timograham@…>

  • Resolution set to fixed
  • Status changed from new to closed

In 407d070329b4df81dab488db35bb068976e3be43:

Fixed #22782 -- Added i18n attr to Sitemap class

It makes possible to have your sitemap in multiple languages when
using i18n in URLs.

comment:10 Changed 14 months ago by Tim Graham <timograham@…>

Note: See TracTickets for help on using tickets.
Back to Top