|Reported by:||hawk@…||Owned by:||adrian|
|Has patch:||yes||Needs documentation:||no|
|Needs tests:||no||Patch needs improvement:||no|
runshell in db/backends/postgresql/client.py passes an argument like "-h somehost" to psql. That doesn't work with my psql binary (7.4.13 from Debian unstable); psql takes the space as part of the host name.
I changed the logic to produce argument lists like this:
['-U', 'someuser', '-W', '-h', 'somehost', 'somedb']
instead of this:
['-U someuser', '-W', '-h somehost', 'somedb']
Also, the code inserts a -W option (prompt for password) when a password is configured, not when there isn't. I inverted that logic.
Change History (6)
Changed 9 years ago by hawk@…
comment:1 Changed 9 years ago by anonymous
- Summary changed from postgres runshell: bad host param, inverted test for -W option to [patch] postgres runshell: bad host param, inverted test for -W option
comment:4 Changed 9 years ago by mtredinnick
- Resolution set to fixed
- Status changed from new to closed