Opened 15 months ago

Closed 15 months ago

Last modified 12 months ago

#22770 closed Cleanup/optimization (fixed)

Remove create_superuser from post_migrate signals

Reported by: timo Owned by: nobody
Component: contrib.auth Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

In IRC, Loic and I were in agreement that the prompt to create a superuser every time after you run migrate can be annoying. Running createsuperuser manually is not much of a burden if you do need it. I think we could make the change without a deprecation as it's not clear to me that doing so would offer any benefits.

Change History (6)

comment:1 Changed 15 months ago by timo

  • Has patch set
  • Triage Stage changed from Unreviewed to Accepted

PR (proposing to include it in 1.7).

comment:2 Changed 15 months ago by manfre

If this type of change was proposed by a non core dev, would it even be considered given that 1.7 is already late in the beta stage?

comment:3 Changed 15 months ago by timo

I added the logic back to syncdb for backwards compatibility. Making the change now means we don't have to worry about people expecting the behavior with migrate.

comment:4 Changed 15 months ago by Tim Graham <timograham@…>

  • Resolution set to fixed
  • Status changed from new to closed

In 93d05536fd8179483c725467de8e33454b48a430:

Fixed #22770 -- Removed create_superuser from post_migrate signals.

Moved logic to syncdb command for backwards compatibility.

comment:5 Changed 15 months ago by Tim Graham <timograham@…>

In 0767055dfc255ba120811f6d9cba2c7e593b0731:

[1.7.x] Fixed #22770 -- Removed create_superuser from post_migrate signals.

Moved logic to syncdb command for backwards compatibility.

Backport of 93d05536fd from master

comment:6 Changed 12 months ago by yoyoma

I created https://github.com/django/django/pull/3143 to address the single remaining documentation straggler.

Note: See TracTickets for help on using tickets.
Back to Top