Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#22725 closed Bug (fixed)

Migration.run_before does nothing

Reported by: Chris Beaven Owned by: Andrew Godwin <andrew@…>
Component: Migrations Version: dev
Severity: Release blocker Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The attribute is there, and the comment shows how it should work (which is exactly what I need).

The code to make it work was non-existant.

Pull request below...

Change History (6)

comment:2 by Andrew Godwin <andrew@…>, 10 years ago

Owner: set to Andrew Godwin <andrew@…>
Resolution: fixed
Status: newclosed

In 5826dc52827254f44833acf678f429af94b4d636:

Merge pull request #2736 from SmileyChris/migration-run_before

Fixed #22725 - Migration.run_before does nothing

comment:3 by Claude Paroz, 10 years ago

Shouldn't this commit be backported to 1.7?

comment:4 by Claude Paroz, 10 years ago

Mmmh, apparently it's in [9f1c4e4d3f997dea150d19ca43d2471d66def120].

comment:5 by Andrew Godwin, 10 years ago

Yeah, I haven't figured out how to backport merges easily yet without just cherry-picking the changes.

comment:6 by Claude Paroz, 10 years ago

I think that cherry-picking is fine, just edit the commit message so that it includes the ticket number.

Note: See TracTickets for help on using tickets.
Back to Top